Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cython: patch to fix w/3.7 from upstream #48379

Closed
wants to merge 1 commit into from
Closed

cython: patch to fix w/3.7 from upstream #48379

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 14, 2018

Upstream fix so tests pass w/python 3.7!

cython/cython#2454

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner October 14, 2018 08:23
@FRidh FRidh self-assigned this Oct 14, 2018
@FRidh
Copy link
Member

FRidh commented Oct 17, 2018

0.29 has been released. Even so, we may want to include this in 18.09.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 18, 2018 via email

@dtzWill
Copy link
Member Author

dtzWill commented Nov 21, 2018

I believe this is dead and no longer needed? Hope so :).

@dtzWill dtzWill closed this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @FRidh @GrahamcOfBorg