python.pkgs.Pyro4: new package (at version 4.74) #49351

prusnak · 2018-10-28T17:09:18Z

Motivation for this change

I noticed that nixpkgs contains only Pyro Python package, which is obsolete now (see https://pypi.org/project/Pyro/) and Pyro4 should be used instead.

This PR contains a package for Pyro4 including its dependency serpent.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Mic92 · 2018-10-28T20:35:23Z

pkgs/top-level/python-packages.nix

@@ -4684,6 +4684,12 @@ in {

  Pyro = callPackage ../development/python-modules/pyro { };


How about removing the old version then?

It seems that openopc uses that :-/

nixpkgs/pkgs/tools/misc/openopc/default.nix

Line 4 in 92a047a

pythonEnv = python.withPackages(ps: [ps.Pyro]);

This project was updated last in 2015. I will propose the removal from nixpkgs.

The package was removed.

The project is dead and it blocks the upgrade of Pyro (NixOS#49351)

includes its dependency python.pkgs.serpent (at version 1.27)

prusnak · 2018-10-29T10:22:34Z

@Mic92 pushed another commit which removes Pyro

Mic92 · 2018-10-29T10:24:03Z

pkgs/top-level/python-packages.nix

+
+  selectors34 = callPackage ../development/python-modules/selectors34 { };
+
+  Pyro4 = callPackage ../development/python-modules/pyro4 { };


Why not keeping the Pyro attribute then instead of renaming it to Pyro4?

Ah upstream calls it Pyro4. Should be ok then.

GrahamcOfBorg · 2018-10-29T10:42:04Z

Success on aarch64-linux (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34

The following builds were skipped because they don't evaluate on aarch64-linux: python27Packages.serpe

Partial log (click to expand)

warning: no previously-included files matching '__pycache__' found anywhere in distribution
writing manifest file 'src/Pyro4.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/pl41q6pf182ll59mrrh37f1bkxajc5j1-python2.7-Pyro4-4.74
/nix/store/1mv39fb5il2niy3cmy30m1hbq7zjd8i7-python2.7-selectors34-1.2

Mic92 · 2018-10-29T10:42:06Z

@GrahamcOfBorg build python27Packages.Pyro4 python27Packages.selectors34 python27Packages.serpent python36Packages.Pyro4 python36Packages.selectors34 python36Packages.serpent

GrahamcOfBorg · 2018-10-29T10:42:09Z

Success on x86_64-linux (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34

The following builds were skipped because they don't evaluate on x86_64-linux: python27Packages.serpe

Partial log (click to expand)

warning: no previously-included files matching '__pycache__' found anywhere in distribution
writing manifest file 'src/Pyro4.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/32pyyx6zrm5kmjk4l5qbbxkn1fvvscrs-python2.7-Pyro4-4.74
/nix/store/cfg08j1axwc9vl465ycdayvkagbxpsqx-python2.7-selectors34-1.2

GrahamcOfBorg · 2018-10-29T10:42:12Z

Success on x86_64-darwin (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.serpe

Partial log (click to expand)

warning: no previously-included files matching '__pycache__' found anywhere in distribution
writing manifest file 'src/Pyro4.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/icvgpyq309zykrkp3nih83jvy7c7k0cv-python2.7-Pyro4-4.74
/nix/store/1wc222wkq49cvhm9wcxi4x9hs8k8v4nk-python2.7-selectors34-1.2

GrahamcOfBorg · 2018-10-29T10:42:32Z

Success on aarch64-linux (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent

Partial log (click to expand)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/pl41q6pf182ll59mrrh37f1bkxajc5j1-python2.7-Pyro4-4.74
/nix/store/1mv39fb5il2niy3cmy30m1hbq7zjd8i7-python2.7-selectors34-1.2
/nix/store/k0i876nqp7cmc9fpksjr7vkcmkghkhpy-python2.7-serpent-1.27
/nix/store/galjkq1d3a5rhk6yzgc6hs3lhkhva08n-python3.6-Pyro4-4.74
/nix/store/aikn1i903w0z56crfi5fi8k9bkwkvhij-python3.6-selectors34-1.2
/nix/store/f53qwczfkfdp1jkxnjp14fgyb47ppzd6-python3.6-serpent-1.27

GrahamcOfBorg · 2018-10-29T10:42:33Z

Success on x86_64-darwin (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent

Partial log (click to expand)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/icvgpyq309zykrkp3nih83jvy7c7k0cv-python2.7-Pyro4-4.74
/nix/store/1wc222wkq49cvhm9wcxi4x9hs8k8v4nk-python2.7-selectors34-1.2
/nix/store/x7iv52g79mf416mxzr9mg753a6arid4p-python2.7-serpent-1.27
/nix/store/40sk73fz6vl9wpc6i8j0gwkjijxsn6lp-python3.6-Pyro4-4.74
/nix/store/ldf44wgvkym8mnrnxga1l3kd1g1y8nvn-python3.6-selectors34-1.2
/nix/store/nj2hy1afx6gcfh5smh1jvix5ykqjisa5-python3.6-serpent-1.27

GrahamcOfBorg · 2018-10-29T10:43:24Z

Success on x86_64-linux (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent

Partial log (click to expand)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/32pyyx6zrm5kmjk4l5qbbxkn1fvvscrs-python2.7-Pyro4-4.74
/nix/store/cfg08j1axwc9vl465ycdayvkagbxpsqx-python2.7-selectors34-1.2
/nix/store/mxj6vcwprkrvrp3s7k771x1iyhj8gzrp-python2.7-serpent-1.27
/nix/store/l043kligxg3vnv754mcqhwc7dkcvzsjx-python3.6-Pyro4-4.74
/nix/store/zk2d14as5nrja7cbvr81iar4y2bb8jf5-python3.6-selectors34-1.2
/nix/store/1lasw7n4vgcghq9nfhmj4xg7rlr5dphy-python3.6-serpent-1.27

Mic92 · 2018-10-29T10:43:29Z

@GrahamcOfBorg build python27Packages.Pyro4 python27Packages.selectors34 python27Packages.serpent python36Packages.Pyro4 python36Packages.selectors34 python36Packages.serpent

GrahamcOfBorg · 2018-10-29T10:43:43Z

Success on aarch64-linux (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent

Partial log (click to expand)

/nix/store/pl41q6pf182ll59mrrh37f1bkxajc5j1-python2.7-Pyro4-4.74
/nix/store/1mv39fb5il2niy3cmy30m1hbq7zjd8i7-python2.7-selectors34-1.2
/nix/store/k0i876nqp7cmc9fpksjr7vkcmkghkhpy-python2.7-serpent-1.27
/nix/store/galjkq1d3a5rhk6yzgc6hs3lhkhva08n-python3.6-Pyro4-4.74
/nix/store/aikn1i903w0z56crfi5fi8k9bkwkvhij-python3.6-selectors34-1.2
/nix/store/f53qwczfkfdp1jkxnjp14fgyb47ppzd6-python3.6-serpent-1.27

GrahamcOfBorg · 2018-10-29T10:43:43Z

Success on x86_64-darwin (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent

Partial log (click to expand)

/nix/store/icvgpyq309zykrkp3nih83jvy7c7k0cv-python2.7-Pyro4-4.74
/nix/store/1wc222wkq49cvhm9wcxi4x9hs8k8v4nk-python2.7-selectors34-1.2
/nix/store/x7iv52g79mf416mxzr9mg753a6arid4p-python2.7-serpent-1.27
/nix/store/40sk73fz6vl9wpc6i8j0gwkjijxsn6lp-python3.6-Pyro4-4.74
/nix/store/ldf44wgvkym8mnrnxga1l3kd1g1y8nvn-python3.6-selectors34-1.2
/nix/store/nj2hy1afx6gcfh5smh1jvix5ykqjisa5-python3.6-serpent-1.27

GrahamcOfBorg · 2018-10-29T10:43:50Z

Success on x86_64-linux (full log)

Attempted: python27Packages.Pyro4, python27Packages.selectors34, python27Packages.serpent, python36Packages.Pyro4, python36Packages.selectors34, python36Packages.serpent

Partial log (click to expand)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/32pyyx6zrm5kmjk4l5qbbxkn1fvvscrs-python2.7-Pyro4-4.74
/nix/store/cfg08j1axwc9vl465ycdayvkagbxpsqx-python2.7-selectors34-1.2
/nix/store/mxj6vcwprkrvrp3s7k771x1iyhj8gzrp-python2.7-serpent-1.27
/nix/store/l043kligxg3vnv754mcqhwc7dkcvzsjx-python3.6-Pyro4-4.74
/nix/store/zk2d14as5nrja7cbvr81iar4y2bb8jf5-python3.6-selectors34-1.2
/nix/store/1lasw7n4vgcghq9nfhmj4xg7rlr5dphy-python3.6-serpent-1.27

prusnak · 2018-10-29T10:46:53Z

Thanks!

prusnak requested a review from FRidh as a code owner October 28, 2018 17:09

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 28, 2018

prusnak force-pushed the add_python_pyro4 branch 3 times, most recently from b4df9cd to 11cd34f Compare October 28, 2018 17:56

Mic92 reviewed Oct 28, 2018

View reviewed changes

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Oct 28, 2018

openopc: remove

c00b2b3

The project is dead and it blocks the upgrade of Pyro (NixOS#49351)

Mic92 mentioned this pull request Oct 28, 2018

openopc: remove #49362

Merged

9 tasks

prusnak added 2 commits October 29, 2018 11:20

python.pkgs.Pyro4: new package (at version 4.74)

e212399

includes its dependency python.pkgs.serpent (at version 1.27)

python.pkgs.Pyro remove package - Pyro4 should be used instead

b7201c5

prusnak force-pushed the add_python_pyro4 branch from 11cd34f to b7201c5 Compare October 29, 2018 10:22

Mic92 reviewed Oct 29, 2018

View reviewed changes

GrahamcOfBorg added the 8.has: clean-up label Oct 29, 2018

Mic92 merged commit 292e47a into NixOS:master Oct 29, 2018

prusnak deleted the add_python_pyro4 branch October 29, 2018 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python.pkgs.Pyro4: new package (at version 4.74) #49351

python.pkgs.Pyro4: new package (at version 4.74) #49351

prusnak commented Oct 28, 2018 •

edited

Mic92 Oct 28, 2018

prusnak Oct 28, 2018 •

edited

Mic92 Oct 28, 2018

Mic92 Oct 28, 2018

Mic92 Oct 29, 2018

prusnak commented Oct 29, 2018

Mic92 Oct 29, 2018 •

edited

Mic92 Oct 29, 2018

prusnak Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

Mic92 commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

Mic92 commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

prusnak commented Oct 29, 2018

		@@ -4684,6 +4684,12 @@ in {

		Pyro = callPackage ../development/python-modules/pyro { };


		selectors34 = callPackage ../development/python-modules/selectors34 { };

		Pyro4 = callPackage ../development/python-modules/pyro4 { };

python.pkgs.Pyro4: new package (at version 4.74) #49351

python.pkgs.Pyro4: new package (at version 4.74) #49351

Conversation

prusnak commented Oct 28, 2018 • edited

Motivation for this change

Things done

Mic92 Oct 28, 2018

Choose a reason for hiding this comment

prusnak Oct 28, 2018 • edited

Choose a reason for hiding this comment

Mic92 Oct 28, 2018

Choose a reason for hiding this comment

Mic92 Oct 28, 2018

Choose a reason for hiding this comment

Mic92 Oct 29, 2018

Choose a reason for hiding this comment

prusnak commented Oct 29, 2018

Mic92 Oct 29, 2018 • edited

Choose a reason for hiding this comment

Mic92 Oct 29, 2018

Choose a reason for hiding this comment

prusnak Oct 29, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Oct 29, 2018

Mic92 commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

Mic92 commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

GrahamcOfBorg commented Oct 29, 2018

prusnak commented Oct 29, 2018

prusnak commented Oct 28, 2018 •

edited

prusnak Oct 28, 2018 •

edited

Mic92 Oct 29, 2018 •

edited