Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma5: 5.14.0 -> 5.14.3 #49377

Merged
merged 1 commit into from Nov 8, 2018
Merged

plasma5: 5.14.0 -> 5.14.3 #49377

merged 1 commit into from Nov 8, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Oct 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner October 29, 2018 08:21
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 31, 2018

Announce and full changelog

@cocreature
Copy link
Contributor

FWIW, plasma 5.14.3 has been released today: announcement and changelog. I haven’t yet attempted to build or use it on NixOS.

@bkchr
Copy link
Contributor Author

bkchr commented Nov 6, 2018

@cocreature ty :) I updated the pull request.

@bkchr bkchr changed the title plasma5: 5.14.0 -> 5.14.2 plasma5: 5.14.0 -> 5.14.3 Nov 6, 2018
@bkchr
Copy link
Contributor Author

bkchr commented Nov 6, 2018

@ttuegel ping

@ttuegel ttuegel merged commit 6b4be56 into NixOS:master Nov 8, 2018
@ttuegel
Copy link
Member

ttuegel commented Nov 8, 2018

Sorry for the delay! Thanks!

@bkchr
Copy link
Contributor Author

bkchr commented Nov 8, 2018

Np :) Ty for the merge.

@bkchr bkchr deleted the plasma_5_14_2 branch November 8, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bkchr @c0bw3b @cocreature @ttuegel @GrahamcOfBorg