Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardnotes: init at 2.3.12 #49370

Closed
wants to merge 0 commits into from
Closed

standardnotes: init at 2.3.12 #49370

wants to merge 0 commits into from

Conversation

M-Gregoire
Copy link
Member

Motivation for this change

Add standardnotes to nixpkgs.
Please note this is my first time doing a derivation, any review is welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@M-Gregoire
Copy link
Member Author

Thank you for you reviews. It should be all good now! If it is, I'll fixup all my commit into one.

@M-Gregoire
Copy link
Member Author

Branch is rebased, everything should be in order 👍

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: standardnotes

Partial log (click to expand)

copying path '/nix/store/fv717vi6byknyfldcp9fd6w0wbbzzhhy-SDL2_mixer-2.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/7prxdsid184xx51ig32ifazbv0hnk11k-SDL_mixer-1.2.12' from 'https://cache.nixos.org'...
copying path '/nix/store/f8scnkmvq1idn4l43hbs8v3kz7yp9zlj-gtk+-2.24.32-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/8rjszgq9cs948agizbc9i8gav8887myp-libappindicator-gtk2-12.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/vlhxpdp12944qp0xhdyb4jnmjlrl4a8a-appimage-run-usr-multi' from 'https://cache.nixos.org'...
copying path '/nix/store/yiy7yz76rav5mn5c8mvifz0lm3r3g1wp-appimage-run-fhs' from 'https://cache.nixos.org'...
copying path '/nix/store/8dhhbda05n0r1k8zgdxin3q6qk5x3cl0-appimage-run-init' from 'https://cache.nixos.org'...
copying path '/nix/store/5mlrr8c4j81zzm0mn4adnil8mbvqip50-appimage-run' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/3gmy4ka4b5m04snj9psbxp0g7rjqqv57-standardNotes-2.3.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3gmy4ka4b5m04snj9psbxp0g7rjqqv57-standardNotes-2.3.11.drv' failed

@NixOS NixOS deleted a comment from GrahamcOfBorg Nov 8, 2018
@dywedir
Copy link
Member

dywedir commented Nov 8, 2018 •
edited

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: standardnotes
Partial log (click to expand)

copying path '/nix/store/fv717vi6byknyfldcp9fd6w0wbbzzhhy-SDL2_mixer-2.0.2' from 'https://cache.nixos.org'...
copying path '/nix/store/7prxdsid184xx51ig32ifazbv0hnk11k-SDL_mixer-1.2.12' from 'https://cache.nixos.org'...
copying path '/nix/store/f8scnkmvq1idn4l43hbs8v3kz7yp9zlj-gtk+-2.24.32-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/8rjszgq9cs948agizbc9i8gav8887myp-libappindicator-gtk2-12.10.0' from 'https://cache.nixos.org'...
copying path '/nix/store/vlhxpdp12944qp0xhdyb4jnmjlrl4a8a-appimage-run-usr-multi' from 'https://cache.nixos.org'...
copying path '/nix/store/yiy7yz76rav5mn5c8mvifz0lm3r3g1wp-appimage-run-fhs' from 'https://cache.nixos.org'...
copying path '/nix/store/8dhhbda05n0r1k8zgdxin3q6qk5x3cl0-appimage-run-init' from 'https://cache.nixos.org'...
copying path '/nix/store/5mlrr8c4j81zzm0mn4adnil8mbvqip50-appimage-run' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/3gmy4ka4b5m04snj9psbxp0g7rjqqv57-standardNotes-2.3.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/3gmy4ka4b5m04snj9psbxp0g7rjqqv57-standardNotes-2.3.11.drv' failed

Hash mismatch
Why do you use "different" (but same) sources btw?

@NixOS NixOS deleted a comment from GrahamcOfBorg Nov 8, 2018
@M-Gregoire
Copy link
Member Author

M-Gregoire commented Nov 9, 2018 •
edited

Thank you for your answer. The release page of standardnotes offers multiple files in the release.

By default, fetchFromGithub takes the source archive (.tar.gz) but I would like to specify another file instead (the .AppImage which is different between architecture). I first thought fetchFromGithub would use the sha256 in order do find the correct file but this is not the case (which seems quite normal after thinking about it...).

Anyway, is there a way to specify which file to download from the release with fetchFromGithub or do I have to use fetchUrl ?

Thank you for your help

EDIT: I will edit my package so It compiles standardnotes from source but I'm still interested of knowing whether It's actually possible to specify a file to fetchFromGithub.

@M-Gregoire M-Gregoire changed the title standardnotes: init at 2.3.11 standardnotes: init at 2.3.12 Nov 9, 2018
@M-Gregoire
Copy link
Member Author

@GrahamcOfBorg build standardnotes

@M-Gregoire
Copy link
Member Author

@dywedir I've been trying to build standardnotes from source but haven't been able to, mostly because this is an electron app. It might be possible to do so but as I'm not experienced enough with nixpkgs at the moment.

In the meanwhile, I'm using the AppImage from the official release and this is working perfectly 👍
I believe this is not a problem but feel free to tell me otherwise.

Thank to all participant who took the time to look at this PR.

@Synthetica9
Copy link
Member

Synthetica9 commented Nov 9, 2018 via email

@dywedir
Copy link
Member

dywedir commented Nov 9, 2018

@M-Gregoire thank you! I'll make some changes, if you don't mind

@M-Gregoire
Copy link
Member Author

Sure, go ahead!

@dywedir dywedir closed this Nov 9, 2018
@dywedir dywedir mentioned this pull request Nov 9, 2018
Merged
@dywedir
Copy link
Member

dywedir commented Nov 9, 2018 •
edited

Whoops, wrong branch, reopened at #50069

@tilpner tilpner mentioned this pull request Jan 27, 2019
Merged
10 tasks
tilpner added a commit to tilpner/nixpkgs that referenced this pull request Feb 1, 2019
@tilpner
appimageTools: init
66eff82 
The appimageTools attrset contains utilities to prevent
the usage of appimage-run to package AppImages, like done/attempted
in NixOS#49370 and NixOS#53156.

This has the advantage of allowing for per-package environment changes,
and extracts into the store instead of the users home directory.

The package list was extracted into appimageTools to prevent
duplication.
tilpner added a commit to tilpner/nixpkgs that referenced this pull request Feb 23, 2019
@tilpner
appimageTools: init
58443d8 
The appimageTools attrset contains utilities to prevent
the usage of appimage-run to package AppImages, like done/attempted
in NixOS#49370 and NixOS#53156.

This has the advantage of allowing for per-package environment changes,
and extracts into the store instead of the users home directory.

The package list was extracted into appimageTools to prevent
duplication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethrokuan jethrokuan jethrokuan left review comments

@Synthetica9 Synthetica9 Synthetica9 left review comments

@symphorien symphorien symphorien left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@M-Gregoire @GrahamcOfBorg @dywedir @Synthetica9 @jethrokuan @symphorien @Janik-Haag