Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cctools: bump to latest commit #49371

Merged
merged 1 commit into from Oct 29, 2018
Merged

cctools: bump to latest commit #49371

merged 1 commit into from Oct 29, 2018

Conversation

matthewbauer
Copy link
Member

Lots of our patches are no longer needed. This simplifies things a
bunch. In addition, it now includes man pages.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
cctools: bump to latest commit
ac682e3 
Lots of our patches are no longer needed. This simplifies things a
bunch. In addition, it now includes man pages.
@LnL7
Copy link
Member

LnL7 commented Oct 28, 2018

Nice, I was also thinking about doing this. Do you know if this fixes nm on 10.14?

$ nm /usr/lib/libSystem.B.dylib
nm: for architecture x86_64 object: /usr/lib/libSystem.B.dylib malformed object (unknown load command 8)

@matthewbauer
Copy link
Member Author

matthewbauer commented Oct 28, 2018 •
edited

No, we'll need apple to release the new tools for that.

tpoechtrager/cctools-port#60

@matthewbauer matthewbauer changed the base branch from master to staging October 29, 2018 00:05
@matthewbauer matthewbauer merged commit bda626e into NixOS:staging Oct 29, 2018
@Ericson2314
Copy link
Member

Ericson2314 commented Oct 29, 2018 •
edited

For iOS we sadly need the old version until either https://lists.llvm.org/pipermail/llvm-dev/2017-September/117264.html is done or we package Apple's LLVM fork. CC @kmicklas. There are some more recent responses to this post in ~August.

@matthewbauer
Copy link
Member Author

Oops! I thought we fixed that one. Have you seen this:

https://github.com/tpoechtrager/apple-libtapi

?

@Ericson2314
Copy link
Member

Doesn't that still contain much vendored LLVM?

@matthewbauer matthewbauer deleted the cctools-bump branch February 22, 2019 04:24
@danieldk danieldk mentioned this pull request Jul 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @LnL7 @Ericson2314 @GrahamcOfBorg