Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KSP-CKAN/CKAN
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e3648d9a6f2a
Choose a base ref
...
head repository: KSP-CKAN/CKAN
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5b548502a0ae
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Oct 23, 2018

  1. Fix null ref exception when repo has empty ckan file

    @HebaruSan
    HebaruSan committed Oct 23, 2018

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    bdc2f76 View commit details

Commits on Oct 28, 2018

  1. Merge #2549 Fix null ref exception when repo has empty ckan file

    @Olympic1
    Olympic1 committed Oct 28, 2018

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Learn about vigilant mode
    Copy the full SHA
    5b54850 View commit details
Showing with 6 additions and 1 deletion.
  1. +1 −0 CHANGELOG.md
  2. +5 −1 Core/Net/Repo.cs
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -30,6 +30,7 @@ All notable changes to this project will be documented in this file.
- [Core] Don't throw exceptions when resetting cache dir (#2547 by: HebaruSan; reviewed: politas)
- [GUI] Fix crash at startup on Windows risen in #2536 (#2557 by: HebaruSan; reviewed: Olympic1)
- [Core] Allow game version of "any" with a vref (#2553 by: HebaruSan; reviewed: Olympic1)
- [Core] Fix null ref exception when repo has empty ckan file (#2549 by: HebaruSan; reviewed: Olympic1)

## v1.25.3 (Woomera)

6 changes: 5 additions & 1 deletion Core/Net/Repo.cs
View file
Original file line number Diff line number Diff line change
@@ -548,7 +548,11 @@ private static CkanModule ProcessRegistryMetadataFromJSON(string metadata, strin
try
{
CkanModule module = CkanModule.FromJson(metadata);
log.DebugFormat("Found {0} version {1}", module.identifier, module.version);
// FromJson can return null for the empty string
if (module != null)
{
log.DebugFormat("Found {0} version {1}", module.identifier, module.version);
}
return module;
}
catch (Exception exception)