Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomachine-client: init at 6.3.6_1 #49352

Merged
merged 1 commit into from Nov 2, 2018
Merged

nomachine-client: init at 6.3.6_1 #49352

merged 1 commit into from Nov 2, 2018

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 28, 2018

Packages mainly the nxplayer part of the client, since the tray
doesn't work very well without the server / a complete installation.

Use the shipped libs, since nxplayer really doesn't like any others. I
believe they use internally modified versions of many libs.

Audio doesn't work: the libasound.so shipped looks for the alsa config
files in the wrong place, and even if it finds them, it still doesn't
work. Using the one from alsaLib doesn't work either and adds
instability.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@talyz
Copy link
Contributor Author

talyz commented Oct 29, 2018

@adisbladis

lib/licenses.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/nomachine-client/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/nomachine-client/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/nomachine-client/default.nix Outdated Show resolved Hide resolved
@talyz
Copy link
Contributor Author

talyz commented Oct 31, 2018

@c0bw3b Thanks for the review! I have addressed all your comments. I also discovered that nxplayer and nxclient have to be wrapped and have access to some additional files; they were working for me only because the path to my development folder was cached in nomachine's settings.

@talyz
Copy link
Contributor Author

talyz commented Nov 1, 2018

Maybe I should have been more clear about this in my last comment: all known issues, except the ones stated in the commit, are now fixed. I've installed it on a second machine with no previous nomachine traces and it works fine there.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 1, 2018

@talyz no problem. It's good to know it's been tested on more than one machine.

@c0bw3b c0bw3b self-assigned this Nov 1, 2018
Packages mainly the nxplayer part of the client, since the tray
doesn't work very well without the server / a complete installation.

Use the shipped libs, since nxplayer really doesn't like any others. I
believe they use internally modified versions of many libs.

Audio doesn't work: the libasound.so shipped looks for the alsa config
files in the wrong place, and even if it finds them, it still doesn't
work. Using the one from alsaLib doesn't work either and adds
instability.
@c0bw3b c0bw3b merged commit 4e8bed5 into NixOS:master Nov 2, 2018
@jirkadanek
Copy link
Member

Thank you for this. Video, mouse and keyboard work fine for me. Sound does not, I reported #52507.

@talyz
Copy link
Contributor Author

talyz commented Dec 19, 2018

Hi! Yes, you're correct - if you look at the original comment, I left a description of this issue there. I would like to get sound working, but it wasn't a deal-breaker for me: better to have something than nothing at all ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants