Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cudnn7.3 over cuda9.0 and make tensorflow use it #49381

Closed
wants to merge 2 commits into from
Closed

Add cudnn7.3 over cuda9.0 and make tensorflow use it #49381

wants to merge 2 commits into from

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Oct 29, 2018

Motivation for this change

Tensorflow over cuda is currently broken because it depends on an incompatible version of cudnn.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jyp jyp requested a review from FRidh as a code owner October 29, 2018 09:36
@FRidh FRidh mentioned this pull request Oct 31, 2018
Merged
9 tasks
@FRidh
Copy link
Member

FRidh commented Oct 31, 2018

I've merged #49476 so please rebase.

@Synthetica9
Copy link
Member

@FRidh This should be made fully obsolete by #49476

@jyp
Copy link
Contributor Author

jyp commented Nov 2, 2018

Correct, closing.

@jyp jyp closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jyp @FRidh @Synthetica9 @GrahamcOfBorg