nix doctor: return nonzero exitcode if a check fails #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use this when testing the installer or when running the checks with other automated tooling.
LnL7
commented
Oct 29, 2018
| success &= checkStoreProtocol(store->getProtocol()); | ||
|
|
||
| if (!success) | ||
| throw Exit(2); |
There was a problem hiding this comment.
Is there something other than the description I can use to document this exit code?
There was a problem hiding this comment.
No, the nix command does not have a man page at the moment.
There was a problem hiding this comment.
It would be nice to have something to provide a longer description that only shows up with nix <command> --help similar to the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use this when testing the installer or when
running the checks with other automated tooling.