Support testing --no-streams as per bug 1501734.

MozillaSecurity · Oct 29, 2018 · 5376ba3 · 5376ba3
1 parent bef4d6a
commit 5376ba3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/src/funfuzz/autobisectjs/known_broken_earliest_working.py b/src/funfuzz/autobisectjs/known_broken_earliest_working.py
@@ -108,6 +108,8 @@ def earliest_known_working_rev(options, flags, skip_revs):  # pylint: disable=mi
     required = []
 
     # These should be in descending order, or bisection will break at earlier changesets.
+    if "--no-streams" in flags:
+        required.append("c6a8b4d451af")  # m-c 442977 Fx65, 1st w/ working --no-streams, see bug 1501734
     if "--enable-streams" in flags:
         required.append("b8c1b5582913")  # m-c 440275 Fx64, 1st w/ working --enable-streams, see bug 1445854
     if "--wasm-gc" in flags:

diff --git a/src/funfuzz/js/shell_flags.py b/src/funfuzz/js/shell_flags.py
@@ -224,6 +224,10 @@ def random_flag_set(shell_path=False):  # pylint: disable=too-complex,too-many-b
         args.append("--no-ion")
 
     # Other flags
+    if shell_supports_flag(shell_path, "--no-streams") and chance(.2):
+        # m-c rev 442977:c6a8b4d451af, see bug 1501734
+        args.append("--no-streams")
+
     if shell_supports_flag(shell_path, "--nursery-strings=on") and chance(.2):
         # m-c rev 406115:321c29f48508, see bug 903519
         args.append("--nursery-strings=" + ("on" if chance(.1) else "off"))

diff --git a/tests/js/test_shell_flags.py b/tests/js/test_shell_flags.py
@@ -113,6 +113,7 @@ def test_random_flag_set(self):
 
         all_flags = js.shell_flags.random_flag_set(self.test_shell_compile())
         assert "--fuzzing-safe" in all_flags
+        assert "--no-streams" in all_flags
         assert "--nursery-strings=on" in all_flags
         assert "--spectre-mitigations=on" in all_flags
         assert "--ion-offthread-compile=on" in all_flags