Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jemalloc: 5.0.1 -> 5.1.0 #49374

Merged
merged 2 commits into from Oct 30, 2018
Merged

jemalloc: 5.0.1 -> 5.1.0 #49374

merged 2 commits into from Oct 30, 2018

Conversation

loskutov
Copy link
Contributor

@loskutov loskutov commented Oct 29, 2018 •
edited

Motivation for this change

new jemalloc upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
    • Built several manually: rustc, cargo, clickhouse, mariadb, okular. The automated CI is probably better at this than my laptop.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

@GrahamcOfBorg build jemalloc

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jemalloc

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0
shrinking /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0/lib/libjemalloc.so.2
gzipping man pages under /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0/lib  /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0/bin
patching script interpreter paths in /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0
/nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0/bin/jemalloc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0/bin/jemalloc-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0...
/nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jemalloc

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0
shrinking /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/lib/libjemalloc.so.2
gzipping man pages under /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/lib  /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/bin
patching script interpreter paths in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0
/nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/bin/jemalloc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/bin/jemalloc-config: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: jemalloc

Partial log (click to expand)

/nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -d /nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/share/man/man3
/nix/store/acnfbicd84bnya2l2dq868b5l482qihw-coreutils-8.30/bin/install -c -m 644 doc/jemalloc.3 /nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/share/man/man3
post-installation fixup
gzipping man pages under /nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/lib  /nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/bin
patching script interpreter paths in /nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0
/nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/bin/jemalloc-config: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0/bin/jemalloc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

Changelog: https://github.com/jemalloc/jemalloc/releases
Let's build a few packages directly depending on this (no, I won't try firefox 😄 )
@GrahamcOfBorg build neovim rsyslog mariadb

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim, rsyslog, mariadb

Partial log (click to expand)

/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/bin/mysql_secure_installation: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/bin/mysql_config: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/bin/msql2mysql: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/bin/mysql_install_db: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/share/mysql/mysql.server: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/share/mysql/wsrep_notify: interpreter directive changed from "/bin/sh -eu" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh -eu"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/share/mysql/binary-configure: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17/share/mysql/mysqld_multi.server: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/m3yj591nkg70bq1d0i9czrd9300rhww4-mariadb-10.2.17...
error: build of '/nix/store/gay28pp87yn60shq7hnyjcijaj8m0c2d-neovim-0.3.1.drv' failed

@loskutov
Copy link
Contributor Author

Oops, it looks like it should be now broken for AArch32 as --disable-thp was removed.

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

neovim is broken on aarch64 without this PR, unrelated issue.

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

Oops, it looks like it should be now broken for AArch32 as --disable-thp was removed.

True. But we don't officially support aarch32 anyway.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: neovim, mariadb

The following builds were skipped because they don't evaluate on x86_64-darwin: rsyslog

Partial log (click to expand)

/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmariadb.3.dylib: fixing dylib
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17/lib/libmysqld.19.dylib: fixing dylib
/nix/store/c4x0bya7ralwyvvb0f23gndrfdnigc3f-neovim-0.3.1
/nix/store/av5d31dbx0prfa5jl5izx6vnv3z4y79r-mariadb-10.2.17

@loskutov
Copy link
Contributor Author

As stated in changelog, jemalloc 5.1 avoids MADV_HUGEPAGE on ARM, so removing this option should be fine

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

just to make sure:
@GrahamcOfBorg build jemalloc

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jemalloc

Partial log (click to expand)

/nix/store/x4jsks46f7ndgj9xhkjjxp7995mnk1jy-jemalloc-5.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: jemalloc

Partial log (click to expand)

/nix/store/42lsjkifndxxzn4i8c3iyl0rijrsan0v-jemalloc-5.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jemalloc

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0
shrinking /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/lib/libjemalloc.so.2
gzipping man pages under /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/lib  /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/bin
patching script interpreter paths in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0
/nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/bin/jemalloc-config: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0/bin/jemalloc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5jgf5gwrd9jhr5ni3dgxxni1bb1ndbrb-jemalloc-5.1.0...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: neovim, rsyslog, mariadb

Partial log (click to expand)

[ 41%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/trx/trx0rseg.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/trx/trx0sys.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/trx/trx0trx.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/trx/trx0undo.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/ut/ut0crc32.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/ut/ut0dbg.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/ut/ut0list.cc.o
[ 42%] Building CXX object storage/innobase/CMakeFiles/innobase_embedded.dir/ut/ut0mem.cc.o
building of '/nix/store/vay1f4815yzql6x0bi90zbm4fijixmdm-mariadb-10.2.17.drv' timed out after 3600 seconds
error: build of '/nix/store/vay1f4815yzql6x0bi90zbm4fijixmdm-mariadb-10.2.17.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

Thank you, LGTM.

@xeji xeji merged commit 933874e into NixOS:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loskutov @xeji @GrahamcOfBorg