Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: disable ocr tests #49357

Merged
merged 1 commit into from Oct 28, 2018
Merged

nixos/plasma5: disable ocr tests #49357

merged 1 commit into from Oct 28, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 28, 2018

This is brittle and breaks the test

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
nixos/plasma5: disable ocr tests
708bdc9 
This is brittle and breaks the test
@Mic92
Copy link
Member Author

Mic92 commented Oct 28, 2018

@GrahamcOfBorg test plasma5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.plasma5

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 93.17s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/fj1ml2cz4rzwbsmd287p54p2nq9nah4i-vm-test-run-plasma5

@Mic92 Mic92 merged commit 894dc67 into NixOS:release-18.09 Oct 28, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.plasma5

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 154.27s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/78z1valmxqpf3r4zibac7fnhgc96da8h-vm-test-run-plasma5

@Mic92 Mic92 deleted the plasma-backport branch October 28, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg