Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avldrums-lv2: init at 0.3.0 #48896

Merged
merged 1 commit into from Nov 1, 2018
Merged

avldrums-lv2: init at 0.3.0 #48896

merged 1 commit into from Nov 1, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 23, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji suggested changes Oct 29, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -577,6 +577,8 @@ with pkgs;

avfs = callPackage ../tools/filesystems/avfs { };

avldrums.lv2 = callPackage ../applications/audio/avldrums.lv2 { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot have a dot in an attribute name because nix will interpret that as the attibute lv2 of the set avldrums, which doesn't make sense (that's why ofborg says zero builds). Please rename consistently to avldrums-lv2 (or another acceptable name).

@magnetophon magnetophon force-pushed the avldrums.lv2 branch 2 times, most recently from 34d6559 to 4714d48 Compare October 31, 2018 13:10
@magnetophon
Copy link
Member Author

@xeji Thanks, done.

@magnetophon magnetophon changed the title avldrums.lv2: init at 0.3.0 avldrums-lv2: init at 0.3.0 Oct 31, 2018
@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build avldrums-lv2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: avldrums-lv2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: avldrums-lv2

Partial log (click to expand)

    lv2ttl/avldrums.gui.in >> build/avldrums.ttl
gcc -Ifluidsynth -I fluidsynth/fluidsynth -DHAVE_CONFIG_H -D DEFAULT_SOUNDFONT=\"\" -Wall -g -Wno-unused-function -DHAVE_LV2_1_8 -msse -msse2 -mfpmath=sse -ffast-math -fomit-frame-pointer -O3 -fno-finite-math-only -DNDEBUG -DVERSION="\"\"" `pkg-config --cflags lv2 glib-2.0` -fPIC -fvisibility=hidden  -std=c99 \
  -o build/avldrums.so src/avldrums.c fluidsynth/src/fluid_midi.c fluidsynth/src/fluid_adsr_env.c fluidsynth/src/fluid_chorus.c fluidsynth/src/fluid_iir_filter.c fluidsynth/src/fluid_lfo.c fluidsynth/src/fluid_rev.c fluidsynth/src/fluid_rvoice.c fluidsynth/src/fluid_rvoice_dsp.c fluidsynth/src/fluid_rvoice_event.c fluidsynth/src/fluid_rvoice_mixer.c fluidsynth/src/fluid_defsfont.c fluidsynth/src/fluid_chan.c fluidsynth/src/fluid_event.c fluidsynth/src/fluid_gen.c fluidsynth/src/fluid_mod.c fluidsynth/src/fluid_synth.c fluidsynth/src/fluid_tuning.c fluidsynth/src/fluid_voice.c fluidsynth/src/fluid_conv.c fluidsynth/src/fluid_hash.c fluidsynth/src/fluid_list.c fluidsynth/src/fluid_ringbuffer.c fluidsynth/src/fluid_settings.c fluidsynth/src/fluid_sys.c \
  -shared -Wl,-Bstatic -Wl,-Bdynamic -Wl,--as-needed -pthread  -lm `pkg-config  --libs glib-2.0`
gcc: error: unrecognized command line option '-msse'; did you mean '-fdse'?
gcc: error: unrecognized command line option '-msse2'
gcc: error: unrecognized command line option '-mfpmath=sse'
make: *** [Makefile:267: build/avldrums.so] Error 1
builder for '/nix/store/fjgx49gnga879y8v14gpsga4ryf4p1hd-avldrums.lv2-0.3.0.drv' failed with exit code 2
error: build of '/nix/store/fjgx49gnga879y8v14gpsga4ryf4p1hd-avldrums.lv2-0.3.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: avldrums-lv2

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0
shrinking /nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0/lib/lv2/avldrums.lv2/avldrums.so
shrinking /nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0/lib/lv2/avldrums.lv2/avldrumsUI_gl.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0/lib
patching script interpreter paths in /nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0
checking for references to /build in /nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0...
/nix/store/l8my6fb1h8lc1nh0yn35qf9zlcvacb2z-avldrums.lv2-0.3.0

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

Looks like aarch64 is not supported (see intel-specific compiler flags), please exclude it from platforms.

@magnetophon
Copy link
Member Author

@xeji Done as well.
Thanks.

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

@GrahamcOfBorg build avldrums-lv2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: avldrums-lv2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: avldrums-lv2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: avldrums-lv2

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0
shrinking /nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0/lib/lv2/avldrums.lv2/avldrumsUI_gl.so
shrinking /nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0/lib/lv2/avldrums.lv2/avldrums.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0/lib
patching script interpreter paths in /nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0
checking for references to /build in /nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0...
/nix/store/xxaxh4wyb9yzxjzbkw2lngqnyvklaqkb-avldrums.lv2-0.3.0

xeji
xeji approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@xeji xeji merged commit 5590565 into NixOS:master Nov 1, 2018
@magnetophon magnetophon deleted the avldrums.lv2 branch November 1, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @xeji @GrahamcOfBorg