nixos/rootston: Remove the module and the package #48905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rootston is just a reference compositor so it doesn't make that much sense to have a module for it. Upstream doesn't really like it as well: "Rootston will never be intended for downstream packages, it's an internal thing we use for testing." - SirCmpwn [0] Removing the package and the module shouldn't cause much problems because it was marked as broken until 886131c. If required the package can still be accessed via wlroots.bin (could be useful for testing purposes). [0]: NixOS#38344 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rootston is just a reference compositor so it doesn't make that much
sense to have a module for it. Upstream doesn't really like it as well:
"Rootston will never be intended for downstream packages, it's an
internal thing we use for testing." - SirCmpwn 0
Removing the package and the module shouldn't cause much problems
because it was marked as broken until
886131c. If required the package can
still be accessed via wlroots.bin (could be useful for testing
purposes).
cc #38344, #48869, #48829
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)