Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote verbose-build and log-lines #2483

Merged
merged 1 commit into from Oct 23, 2018
Merged

Conversation

lheckemann
Copy link
Member

These are now fully-qualified options, allowing commands like

nix build --verbose-build nixpkgs.hello
nix build --log-lines 30 nixpkgs.hello

In order to obtain more information in case of a failure.

cc @colemickens who was asking about this on IRC, @gilligan who was asking about this on twitter :)

@edolstra
Copy link
Member

--log-lines is fine, but --verbose-build is not because it doesn't work well (e.g. output from concurrent builds is interspersed, with no way to tell what about came from what build).

@lheckemann
Copy link
Member Author

That's no different from nix-build though, right?

This allows commands like

nix build --log-lines 30 nixpkgs.hello

in order to obtain more information in case of a failure.
@lheckemann
Copy link
Member Author

In any case, I've pushed a new version that only promotes log-lines, and will have a look at what we could do for verbose build.

@lheckemann
Copy link
Member Author

(original version of this PR consisted of c82db2a for future reference)

@edolstra
Copy link
Member

Yes, but nix build is supposed to improve upon nix-build UI rather than reproduce all its warts.

@edolstra edolstra merged commit c47e14e into NixOS:master Oct 23, 2018
@lheckemann lheckemann deleted the tail-config branch October 23, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants