Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: 11.3.1 -> 11.4.0 #48867

Merged
merged 1 commit into from Oct 23, 2018
Merged

gitlab-runner: 11.3.1 -> 11.4.0 #48867

merged 1 commit into from Oct 23, 2018

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 23, 2018

Motivation for this change

https://gitlab.com/gitlab-org/gitlab-runner/blob/8af42251eebf1922576b5f8179590138ef8a4e30/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg build gitlab-runner

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitlab-runner

Partial log (click to expand)

find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
find: '/nix/store/8i3a74hykx1im2wc32wf9p20m3rw19mv-gitlab-runner-11.4.0': No such file or directory
/nix/store/qp16wj0hlmrah5yrpnah2nlp2rksngjx-gitlab-runner-11.4.0-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitlab-runner

Partial log (click to expand)

        /nix/store/dx05isnz54xqw03sm2vzi35nfl0i41dp-go-1.11/share/go/src/runtime/asm_arm64.s:1114 +0x4 fp=0x40000de7d0 sp=0x40000de7d0 pc=0x61f34
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/reference
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/pkg/pools
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/api/types/reference
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/prometheus/client_model/go
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/matttproud/golang_protobuf_extensions/pbutil
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/prometheus/common/expfmt
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/pkg/jsonmessage
builder for '/nix/store/qsz2acxks1zv5i0hy3c5jl1i0gwa947l-gitlab-runner-11.4.0.drv' failed with exit code 26
error: build of '/nix/store/qsz2acxks1zv5i0hy3c5jl1i0gwa947l-gitlab-runner-11.4.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab-runner

Partial log (click to expand)

shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/pull-images-for-tests
shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/gitlab-runner
shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/gitlab-runner-helper
shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/scripts
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin
patching script interpreter paths in /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin
checking for references to /build in /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

aarch64 failure looks like a builder-specific problem (lack of resources). Let's try again.
@GrahamcOfBorg build gitlab-runner

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitlab-runner

Partial log (click to expand)

/nix/store/qp16wj0hlmrah5yrpnah2nlp2rksngjx-gitlab-runner-11.4.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab-runner

Partial log (click to expand)

shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/gitlab-runner
shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/pull-images-for-tests
shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/gitlab-runner-helper
shrinking /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin/scripts
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin/bin
patching script interpreter paths in /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin
checking for references to /build in /nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/nyvjwdnlwwnyx6m428h09wgvgmgfy530-gitlab-runner-11.4.0-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitlab-runner

Partial log (click to expand)

runtime.main()
        /nix/store/dx05isnz54xqw03sm2vzi35nfl0i41dp-go-1.11/share/go/src/runtime/proc.go:130 +0x54 fp=0x40000de7d0 sp=0x40000de790 pc=0x39464
runtime.goexit()
        /nix/store/dx05isnz54xqw03sm2vzi35nfl0i41dp-go-1.11/share/go/src/runtime/asm_arm64.s:1114 +0x4 fp=0x40000de7d0 sp=0x40000de7d0 pc=0x61f34
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/distribution/reference
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/pkg/idtools
gitlab.com/gitlab-org/gitlab-runner/vendor/github.com/docker/docker/api/types/reference
gitlab.com/gitlab-org/gitlab-runner/vendor/gitlab.com/ayufan/golang-cli-helpers
builder for '/nix/store/qsz2acxks1zv5i0hy3c5jl1i0gwa947l-gitlab-runner-11.4.0.drv' failed with exit code 27
error: build of '/nix/store/qsz2acxks1zv5i0hy3c5jl1i0gwa947l-gitlab-runner-11.4.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

Same error on a different builder. @bachp have you encountered this aarch64 failure before?

@xeji xeji mentioned this pull request Oct 23, 2018
Merged
7 tasks
@bachp
Copy link
Member Author

bachp commented Oct 23, 2018

@xeji I think there were already issues with the aarch64 build last update.

However I was not able to reproduce them as they successfully build on my Raspberry Pi3. I even thought there were binaries available form cache.nixos.org (not 100% sure and can't check right now).

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

Yes, the current version builds on hydra for aarch64. So let's assume this is an ofborg-only error and merge it anyway. Please check the aarch64 build in the next hydra evaluation.

@xeji xeji merged commit 7863610 into NixOS:master Oct 23, 2018
@bachp bachp deleted the gitlab-runner-11.4.0 branch October 23, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @xeji @GrahamcOfBorg