Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwm-settings-manager: init at 2018-10-19 #48873

Merged
merged 1 commit into from Oct 30, 2018
Merged

jwm-settings-manager: init at 2018-10-19 #48873

merged 1 commit into from Oct 30, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 23, 2018

Motivation for this change

Add jwm-settings-manager.

A full configuration manager for JWM, enabling the average user the ability to customize JWM to their liking. Built using FLTK and pugixml, this is a fast and light application to configure one of the fastest lightest Window Managers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19
shrinking /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19/bin/desktop-file-editor
shrinking /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19/bin/fltk-mouse
shrinking /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19/bin/jwm-settings-manager
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19/lib  /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19/bin
patching script interpreter paths in /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19
checking for references to /build in /nix/store/a80j3x8gp2g7fym443qn9ag088ys0069-jwm-settings-manager-2018-10-19...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19
shrinking /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19/bin/desktop-file-editor
shrinking /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19/bin/fltk-mouse
shrinking /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19/bin/jwm-settings-manager
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19/lib  /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19/bin
patching script interpreter paths in /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19
checking for references to /build in /nix/store/z27rvyjs1r5fh9c4dlm8ai1r1vp7gs8x-jwm-settings-manager-2018-10-19...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

                        ^
/nix/store/vdbia3wglg1y6pjshgsy1viz8r0k09bg-xproto-7.0.31/include/X11/X.h:96:13: note: previous definition is here
typedef XID Window;
            ^
1 error generated.
make[2]: *** [CMakeFiles/JSM.dir/build.make:63: CMakeFiles/JSM.dir/src/ui.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:110: CMakeFiles/JSM.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/bvyqdh89161n25hyjk0zgs43nxc8b86i-jwm-settings-manager-2018-10-19.drv' failed with exit code 2
error: build of '/nix/store/bvyqdh89161n25hyjk0zgs43nxc8b86i-jwm-settings-manager-2018-10-19.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19
shrinking /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19/bin/desktop-file-editor
shrinking /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19/bin/fltk-mouse
shrinking /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19/bin/jwm-settings-manager
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19/lib  /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19/bin
patching script interpreter paths in /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19
checking for references to /build in /nix/store/dx4sq7y86zfmwlk34fc7cpk57k9fnrv4-jwm-settings-manager-2018-10-19...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19
shrinking /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19/bin/jwm-settings-manager
shrinking /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19/bin/desktop-file-editor
shrinking /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19/bin/fltk-mouse
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19/lib  /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19/bin
patching script interpreter paths in /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19
checking for references to /build in /nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19...
/nix/store/vqmwji7kscy66bnra1pmag3nnhxwsnkl-jwm-settings-manager-2018-10-19

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

                        ^
/nix/store/vdbia3wglg1y6pjshgsy1viz8r0k09bg-xproto-7.0.31/include/X11/X.h:96:13: note: previous definition is here
typedef XID Window;
            ^
1 error generated.
make[2]: *** [CMakeFiles/JSM.dir/build.make:63: CMakeFiles/JSM.dir/src/ui.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:110: CMakeFiles/JSM.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/9487yvqw4i5kzdayycz5wwycr15f9wqj-jwm-settings-manager-2018-10-19.drv' failed with exit code 2
error: build of '/nix/store/9487yvqw4i5kzdayycz5wwycr15f9wqj-jwm-settings-manager-2018-10-19.drv' failed

xeji
xeji reviewed Oct 30, 2018
View reviewed changes
pkgs/applications/window-managers/jwm/jwm-settings-manager.nix Outdated
libGL
fltk
hicolor-icon-theme
which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is which really used at runtime? If not, it belongs in nativeBuildInputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, which is used at runtime to locate optional executables.

pkgs/applications/window-managers/jwm/jwm-settings-manager.nix Outdated
description = "A full configuration manager for JWM";
homepage = https://joewing.net/projects/jwm;
license = licenses.gpl3;
platforms = platforms.unix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to work on MacOS? Please either fix the Darwin build or restrict platforms to linux.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As JWM is an X11 WM, I guess macOS support for editing its configuration is not too useful, even if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changing it to linux.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: jwm-settings-manager

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19
shrinking /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19/bin/desktop-file-editor
shrinking /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19/bin/fltk-mouse
shrinking /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19/bin/jwm-settings-manager
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19/lib  /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19/bin
patching script interpreter paths in /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19
checking for references to /build in /nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19...
/nix/store/hg8rzxrnvc2x7ab7jzvjz7z3csm4s962-jwm-settings-manager-2018-10-19

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jwm-settings-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19
shrinking /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19/bin/desktop-file-editor
shrinking /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19/bin/fltk-mouse
shrinking /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19/bin/jwm-settings-manager
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19/lib  /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19/bin
patching script interpreter paths in /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19
checking for references to /build in /nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19...
/nix/store/hxxd1fiv3wd7b63k560qgnjp8bl6cy16-jwm-settings-manager-2018-10-19

@7c6f434c 7c6f434c merged commit 1d8794e into NixOS:master Oct 30, 2018
@romildo romildo deleted the new.jwm-settings-manager branch October 30, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @GrahamcOfBorg @7c6f434c @xeji