Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licenses #48909

Merged
merged 13 commits into from Oct 24, 2018
Merged

Add licenses #48909

merged 13 commits into from Oct 24, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Another round for #43716

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked more than half and I'm good with this lot

@markuskowa
Copy link
Member Author

@c0bw3b appreciate the double checking. There's a lot of room for error in this business.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 23, 2018

Yes indeed, especially when you start a routine for lots of small changes.
But as a reviewer I think it's only fair to support your ongoing effort on this matter :)

@xeji xeji merged commit 5371596 into NixOS:master Oct 24, 2018
@markuskowa markuskowa deleted the licenses-23 branch October 27, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @c0bw3b @GrahamcOfBorg @xeji