Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CKAN shouldn't try to write files to drives that don't have enough free space #1236

Closed
gsarducci opened this issue Jul 4, 2015 · 10 comments
Closed

CKAN shouldn't try to write files to drives that don't have enough free space #1236

gsarducci opened this issue Jul 4, 2015 · 10 comments
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Windows Issues specific for Windows ★★☆
Milestone
Temp File Issues

Comments

@gsarducci
Copy link

I have CKAN in a local h:/KSP directory. Upon executing an install of Realism Overhaul using CKAN, it begins dumping temp files into G:/AppData/Local/Temp. This drive is in reality a dummy partition for a Linux boot that only has 256MB of space, so predictably it runs out of space and CKAN nukes with an exception.
@gsarducci
Copy link
Author

image

@Postremus Postremus added Bug Something is not working as intended ★★☆ labels Jul 4, 2015
@Postremus
Copy link
Contributor

Does this also happen when you try to install RO using the cli?

@Postremus
Copy link
Contributor

"ckan install RealismOverhaul" should be the command for doing that.

@gsarducci
Copy link
Author

Ran command line and it threw a different error, but I did watch the G: drive as it was happening and it still was depositing temp files in there. This time though when the program stopped it cleaned up. The GUI didn't, instead leaving all the temp files in there. Anyway, screen shot coming.

@Postremus Postremus added the Core (ckan.dll) Issues affecting the core part of CKAN label Jul 4, 2015
@gsarducci

This comment was marked as off-topic.

Sign in to view
@gsarducci
Copy link
Author

Interestingly, if I run it a few times via CLI it works. I imagine it's because it already has some of the data downloaded so every time I go to run it it has to fetch less and eventually can accomplish what it needs to do within the limitations of the "G" drive.

@Postremus Postremus changed the title Dumping Temp Files on Different Drives CKAN shouldn't try to save on drives with to less empty space Jul 4, 2015
@Dazpoet
Copy link
Member

Dazpoet commented Aug 18, 2015

An explanation to the above is probably that it downloads one/a few mods and upon nuking itself with the exception moves all already done downloads to the cache. So every attempt you finish part of the process, just like you thought :)

@Postremus Postremus added this to the Temp File Issues milestone Aug 20, 2015
@mheguy mheguy changed the title CKAN shouldn't try to save on drives with to less empty space CKAN shouldn't try to write files to drives that don't have enough free space Aug 27, 2015
@mheguy mheguy mentioned this issue Aug 27, 2015
Closed
@politas
Copy link
Member

politas commented Oct 23, 2018

Has this been sorted out by #2535 and #2536?

Sorry, something went wrong.

@politas politas closed this as completed Oct 23, 2018
@politas politas reopened this Oct 23, 2018
@HebaruSan
Copy link
Member

No, I don't think so. The AppData/Local/Temp part of it sounds like this is happening during the download itself, which saves to a temp file (from Path.GetTempFileName() or FileTransaction.GetTempFileName()), rather than when we copy the temp file into the cache.

CKAN/Core/Net/NetAsyncDownloader.cs

Line 48 in b9a91fa

this.path = path ?? Path.GetTempFileName();

CKAN/Core/Net/Net.cs

Line 137 in b9a91fa

? FileTransaction.GetTempFileName()

In this case the best solution is probably to not configure the Windows %TEMP% path to point to a full partition.

Sorry, something went wrong.

@HebaruSan HebaruSan added Windows Issues specific for Windows and removed Bug Something is not working as intended labels May 16, 2020
@HebaruSan
Copy link
Member

I don't think it makes sense to try to make downloads succeed with a full system temp folder. The files have to go somewhere.

@HebaruSan HebaruSan mentioned this issue Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Windows Issues specific for Windows ★★☆
Projects
None yet
Milestone
Temp File Issues
Development

No branches or pull requests
5 participants
@Postremus @HebaruSan @politas @gsarducci @Dazpoet