Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sh: 1.11 -> 1.12.14 #48892

Merged
merged 3 commits into from Oct 29, 2018
Merged

pythonPackages.sh: 1.11 -> 1.12.14 #48892

merged 3 commits into from Oct 29, 2018

Conversation

sveitser
Copy link
Contributor

Motivation for this change

Package update.

Things done
  • "Modernize" to the best of my knowledge.
  • Enable unit tests.
  • Add MIT license.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (python2 and 3)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@sveitser
pythonPackages.sh: 1.11 -> 1.12.14
9f327ca 
- Enable unit tests.
- Add MIT license.
@sveitser sveitser requested a review from FRidh as a code owner October 23, 2018 15:34
FRidh
FRidh requested changes Oct 24, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

pkgs/top-level/python-packages.nix Outdated
};

doCheck = false;
buildInputs = with self; [ coverage ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkInputs

pkgs/top-level/python-packages.nix Outdated

# A test needs the HOME directory to be different from $TMPDIR.
preCheck = ''
HOME=$(mktemp -d)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@sveitser
Copy link
Contributor Author

@FRidh thanks. I made the changes.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.sh python3.pkgs.sh

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.sh, python3.pkgs.sh

Partial log (click to expand)

test_chunk_buffered (test.StreamBuffererTests) ... ok
test_newline_buffered (test.StreamBuffererTests) ... ok
test_unbuffered (test.StreamBuffererTests) ... ok

----------------------------------------------------------------------
Ran 156 tests in 51.859s

OK (skipped=2)
/nix/store/7gf2vp1ldjbx7wypzgmb5nf521k36vdv-python2.7-sh-1.12.14
/nix/store/5qzzgxphwpgbh9l7gqwv20b2yi5g6rcy-python3.6-sh-1.12.14

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python2.pkgs.sh, python3.pkgs.sh

Partial log (click to expand)



----------------------------------------------------------------------
Ran 156 tests in 44.960s

FAILED (errors=2, skipped=2)
Test failed: <unittest.runner.TextTestResult run=156 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=156 errors=2 failures=0>
builder for '/nix/store/rahc98r5xahc3kqinrwka5ryci996v8r-python3.6-sh-1.12.14.drv' failed with exit code 1
error: build of '/nix/store/4id5h3wyijxph7w3b3v8g2k4sgcjb6c3-python2.7-sh-1.12.14.drv', '/nix/store/rahc98r5xahc3kqinrwka5ryci996v8r-python3.6-sh-1.12.14.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.sh, python3.pkgs.sh

Partial log (click to expand)

test_chunk_buffered (test.StreamBuffererTests) ... ok
test_newline_buffered (test.StreamBuffererTests) ... ok
test_unbuffered (test.StreamBuffererTests) ... ok

----------------------------------------------------------------------
Ran 156 tests in 62.206s

OK (skipped=2)
/nix/store/y3x907vyy31rckcnbrjdbdk93249x9p1-python2.7-sh-1.12.14
/nix/store/051rnspbsyzxn0q6rkzb96xmn82mr0n6-python3.6-sh-1.12.14

@dotlambda dotlambda merged commit 8f415fd into NixOS:master Oct 29, 2018
@sveitser sveitser deleted the update/pythonPackages.sh branch November 5, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sveitser @dotlambda @GrahamcOfBorg @FRidh