Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: add perl.withPackages #48815

Merged
merged 1 commit into from Oct 23, 2018
Merged

weechat: add perl.withPackages #48815

merged 1 commit into from Oct 23, 2018

Conversation

alyssais
Copy link
Member

Allows for adding Perl libraries in the same way as for Python. Doesn't really need to be a function, since there's only one perlPackages in nixpkgs, but I went for consistency with the python plugin.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais
weechat: add perl.withPackages
6e55738 
Allows for adding Perl libraries in the same way as for Python. Doesn't
really need to be a function, since there's only one perlPackages in
nixpkgs, but I went for consistency with the python plugin.
@Mic92 Mic92 requested a review from Ma27 October 22, 2018 13:46
Ma27
Ma27 approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally, seems to work fine 👍

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/afis92vapvbqm0mbybbw9nd0pp03f12m-guile-2.0.13' from 'https://cache.nixos.org'...
copying path '/nix/store/sl4bbwf02a40lip2kcwy8i5nx8jj479z-weechat-2.2' from 'https://cache.nixos.org'...
copying path '/nix/store/lh8h8alz2jbq8m998ikbc6534cln171d-weechat-2.2-tcl' from 'https://cache.nixos.org'...
copying path '/nix/store/lkyrqdswy01sb92pg7n1ci0gbsgyd7j3-weechat-2.2-guile' from 'https://cache.nixos.org'...
copying path '/nix/store/z00j63dsvy5lb79dk15s0amc2qi1gah3-weechat-2.2-ruby' from 'https://cache.nixos.org'...
copying path '/nix/store/skm6v5cll9c8myl39pgh01bfycy36jfv-weechat-plugins' from 'https://cache.nixos.org'...
copying path '/nix/store/n4g09r8h9zjq2c2ywfnp0ayi0dynqspa-weechat' from 'https://cache.nixos.org'...
copying path '/nix/store/ji9kdlz6sbjvcjdfcpx0w84hxzqm1sb7-weechat-headless' from 'https://cache.nixos.org'...
copying path '/nix/store/2l1cg3dn7vi4zxa6wrrwjwiczcsr1p82-weechat-bin-env-2.2' from 'https://cache.nixos.org'...
/nix/store/2l1cg3dn7vi4zxa6wrrwjwiczcsr1p82-weechat-bin-env-2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/4mflznxkx5wj3nm52w2yzaaz81mv3yjq-weechat-2.2-lua' from 'https://cache.nixos.org'...
copying path '/nix/store/kj68b3kr6ffh9nhha2svgvlqvdvyza3k-weechat-2.2-perl' from 'https://cache.nixos.org'...
copying path '/nix/store/vhqlnpxqan0mx7ppcx8zvm6dx7fa0z94-weechat-2.2-python' from 'https://cache.nixos.org'...
copying path '/nix/store/0hnnjgkzs93g1w8334pxlka8y2nb04gw-weechat-2.2-ruby' from 'https://cache.nixos.org'...
copying path '/nix/store/l83153dqnnw3q8ihpxxzzkgp5v5bay52-weechat-2.2-tcl' from 'https://cache.nixos.org'...
copying path '/nix/store/jgqyzj65wmkbvs5qm8n9sm0l9j34429y-weechat-plugins' from 'https://cache.nixos.org'...
copying path '/nix/store/g68wi4698mr1hl2m0pvm0jjm3yzv7h1v-weechat' from 'https://cache.nixos.org'...
copying path '/nix/store/w3mq5j79pzmqgivp7dd2242ldl929z42-weechat-headless' from 'https://cache.nixos.org'...
copying path '/nix/store/zxmmaph4qyv4qasp6d44nb1vmh9fpxa1-weechat-bin-env-2.2' from 'https://cache.nixos.org'...
/nix/store/zxmmaph4qyv4qasp6d44nb1vmh9fpxa1-weechat-bin-env-2.2

@xeji xeji merged commit e20e1e5 into NixOS:master Oct 23, 2018
@alyssais alyssais deleted the weechat_perl_packages branch November 2, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @xeji @GrahamcOfBorg @Ma27