Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libibverbs,librdmacm: remove in favour of rdma-core #48899

Merged
merged 1 commit into from Nov 10, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

libibverbs and librdmacm are outdated and have been replaced by the package rdma-core. Their latest version in nixpkgs was from 2014 (https://downloads.openfabrics.org/verbs). All dependencies to these two packages have now been removed in nixpkgs (#34314).

rdma-core contains up-to-date versions of both libraries.

See #33090 and #34314 for details.

Things done

Removed both packages.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

libibverbs and librdmacm are outdated and have
been replaced by the package rdma-core
@markuskowa
Copy link
Member Author

CC @wkennington @bzizou

@markuskowa
Copy link
Member Author

CC @matthewbauer

@Mic92 Mic92 merged commit 7ce08cb into NixOS:master Nov 10, 2018
Picking up garbage automation moved this from To do to Done Nov 10, 2018
@markuskowa markuskowa deleted the clean-rdma branch November 20, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants