Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

featherpad: init at 0.9.1 #48868

Merged
merged 1 commit into from Oct 26, 2018
Merged

featherpad: init at 0.9.1 #48868

merged 1 commit into from Oct 26, 2018

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Oct 23, 2018

Motivation for this change

I like to use featherpad @ nixos ;-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Oct 24, 2018
View reviewed changes
pkgs/applications/editors/featherpad/default.nix Outdated
stdenv.mkDerivation rec {
version = "0.9.1";
name = "featherpad-${version}";
src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use fetchFromGitHub?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@nlewo
Copy link
Member

nlewo commented Oct 26, 2018

@GrahamcOfBorg build featherpad

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: featherpad

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: featherpad

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/sjangg7akmizl7w7f5908w8w0yna779l-featherpad-0.9.1
shrinking /nix/store/sjangg7akmizl7w7f5908w8w0yna779l-featherpad-0.9.1/bin/featherpad
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sjangg7akmizl7w7f5908w8w0yna779l-featherpad-0.9.1/bin
patching script interpreter paths in /nix/store/sjangg7akmizl7w7f5908w8w0yna779l-featherpad-0.9.1
checking for references to /build in /nix/store/sjangg7akmizl7w7f5908w8w0yna779l-featherpad-0.9.1...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/sjangg7akmizl7w7f5908w8w0yna779l-featherpad-0.9.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: featherpad

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/fw2cfzf8h4mlc1qwbxzc4mxynw3igv5r-featherpad-0.9.1
shrinking /nix/store/fw2cfzf8h4mlc1qwbxzc4mxynw3igv5r-featherpad-0.9.1/bin/featherpad
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fw2cfzf8h4mlc1qwbxzc4mxynw3igv5r-featherpad-0.9.1/bin
patching script interpreter paths in /nix/store/fw2cfzf8h4mlc1qwbxzc4mxynw3igv5r-featherpad-0.9.1
checking for references to /build in /nix/store/fw2cfzf8h4mlc1qwbxzc4mxynw3igv5r-featherpad-0.9.1...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/fw2cfzf8h4mlc1qwbxzc4mxynw3igv5r-featherpad-0.9.1

@nlewo nlewo merged commit e87de3f into NixOS:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flosse @nlewo @GrahamcOfBorg