Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra: 2.3.4 -> 2.4 #48872

Closed
wants to merge 1 commit into from
Closed

xpra: 2.3.4 -> 2.4 #48872

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xpra/versions.

meta.description for xpra is: '"Persistent remote applications for X"'.

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/xpra_Xdummy had a zero exit code or showed the expected version
  • /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/xpra passed the binary check.
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/xpra_browser had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/xpra_launcher had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/xpra_signal_listener had a zero exit code or showed the expected version
  • /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/xpra_udev_product_version passed the binary check.
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/.xpra_Xdummy-wrapped had a zero exit code or showed the expected version
  • /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/.xpra_udev_product_version-wrapped passed the binary check.
  • /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/..xpra-wrapped-wrapped passed the binary check.
  • /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/.xpra-wrapped passed the binary check.
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/..xpra_browser-wrapped-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/.xpra_browser-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/..xpra_launcher-wrapped-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/.xpra_launcher-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/..xpra_signal_listener-wrapped-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin/.xpra_signal_listener-wrapped had a zero exit code or showed the expected version
  • 5 of 16 passed binary check by having a zero exit code.
  • 0 of 16 passed binary check by having the new version present in output.
  • found 2.4 with grep in /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4
  • directory tree listing: https://gist.github.com/75389ae47aa028221fdbf5dbfe9bf821
  • du listing: https://gist.github.com/06d9ecc0f890ca2b3f2378e5deb43d12
Outpath report (click to expand)

Outpath difference report
12 total rebuild paths

4 package rebuilds

0 x86_64-darwin rebuilds
4 x86_64-linux rebuilds
4 aarch64-linux rebuilds

First ten rebuilds by attrpath
ib-controllerrun-scaledwinswitchxpra

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A xpra https://github.com/r-ryantm/nixpkgs/archive/cddc59e7def3dc4191ceb9c9aeaf8d3bbe7b85a9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4
ls -la /nix/store/gprsgpvjwgaw9vpcq8dqyiv07fcaa98i-xpra-2.4/bin

cc @offlinehacker @numinit for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/xpra/versions
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xpra

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xpra

Partial log (click to expand)

/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/lib/xpra/auth_dialog: interpreter directive changed from "/usr/bin/env python" to "/nix/store/16wqq9ihrkdim3x8xs1lkxa3f4l3p3ir-python3-3.6.6/bin/python"
/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/lib/xpra/gnome-open: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/lib/xpra/gvfs-open: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/lib/xpra/xdg-open: interpreter directive changed from "/usr/bin/env python" to "/nix/store/16wqq9ihrkdim3x8xs1lkxa3f4l3p3ir-python3-3.6.6/bin/python"
checking for references to /build in /nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4...
wrapping `/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/bin/.xpra_signal_listener-wrapped'...
wrapping `/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/bin/.xpra_launcher-wrapped'...
wrapping `/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/bin/.xpra_browser-wrapped'...
wrapping `/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4/bin/.xpra-wrapped'...
/nix/store/13qyh3v2zy5d4c2lxnd8jdf9l7r8lkzw-xpra-2.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xpra

Partial log (click to expand)

/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/lib/xpra/gnome-open: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/lib/xpra/gvfs-open: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/bin/.xpra_udev_product_version-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/bin/.xpra_Xdummy-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4...
wrapping `/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/bin/.xpra_launcher-wrapped'...
wrapping `/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/bin/.xpra_signal_listener-wrapped'...
wrapping `/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/bin/.xpra-wrapped'...
wrapping `/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4/bin/.xpra_browser-wrapped'...
/nix/store/blr7a4kg4cb1srnb60jfp82fa7ba1ms7-xpra-2.4

@infinisil
Copy link
Member

xpra seems to be broken. This patch solved the first couple issues:

diff --git a/pkgs/tools/X11/xpra/default.nix b/pkgs/tools/X11/xpra/default.nix
index f6d6a0f50b0..8b0d70c473b 100644
--- a/pkgs/tools/X11/xpra/default.nix
+++ b/pkgs/tools/X11/xpra/default.nix
@@ -70,7 +70,7 @@ in buildPythonApplication rec {
   preFixup = ''
     gappsWrapperArgs+=(
       --set XPRA_INSTALL_PREFIX "$out"
-      --prefix LD_LIBRARY_PATH : ${libfakeXinerama}/lib
+      --prefix LD_LIBRARY_PATH : ${stdenv.lib.makeLibraryPath [ libfakeXinerama xorg.libXdamage xorg.libXfixes xorg.libXext xorg.libX11 ]}
       --prefix PATH : ${stdenv.lib.makeBinPath [ getopt xorgserver xauth which utillinux pulseaudio ]}
     )
   '';

But then I get

$ result/bin/xpra start ssh/infinisil@infinisil.com --start-child=xterm
2018-10-27 00:23:50,014 Xpra gtk3 client version 2.4-r20681 64-bit
2018-10-27 00:23:50,015  running on Linux
2018-10-27 00:23:50,016  window manager is 'xmonad'
2018-10-27 00:23:50,049 Warning: failed to import opencv:
2018-10-27 00:23:50,049  No module named 'cv2'
2018-10-27 00:23:50,050  webcam forwarding is disabled
2018-10-27 00:23:50,513 GStreamer version 1.14.2 for Python 3.6.6 64-bit
2018-10-27 00:23:50,584 Warning: failed to load the GTK3 notification class
2018-10-27 00:23:50,584  Namespace Notify not available
2018-10-27 00:23:50,784 Warning: cannot import native OpenGL module
2018-10-27 00:23:50,784  No module named 'OpenGL'
2018-10-27 00:23:50,784 Warning: no OpenGL backends found
xpra initialization error:
 connection failed: No module named 'paramiko'

And I have no idea how to fix this. Ping @offlinehacker @numinit

This package should probably be marked broken until this can be fixed

@samueldr
Copy link
Member

@Lassulus and I also (separately) checked for xpra recently. (Pinging in case there's interest.)

Though, I thought xpra was only half-broken, but trying to use xpra shadow fails miserably right now. Sighs. Looks like there's a bunch of path hardcoding inside xpra (it tries to generate a ~/.xpra/run-xpra helper, among others).

+1 for marking broken.

@infinisil infinisil mentioned this pull request Nov 14, 2018
9 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2018

We also maintain libfakeXinerama just for xpra ...

Closing this for now

@c0bw3b c0bw3b closed this Nov 17, 2018
@r-ryantm r-ryantm deleted the auto-update/xpra branch November 17, 2018 23:13
@c0bw3b c0bw3b mentioned this pull request Dec 11, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants