Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ats2: 0.3.11 -> 0.3.12 #48877

Merged
merged 1 commit into from Oct 24, 2018
Merged

ats2: 0.3.11 -> 0.3.12 #48877

merged 1 commit into from Oct 24, 2018

Conversation

bbarker
Copy link
Contributor

@bbarker bbarker commented Oct 23, 2018

Motivation for this change

Updating ATS2 to a version (the latest version) that supports building ATS3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build ats2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ats2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ats2

Partial log (click to expand)

shrinking /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/lib/ats2-postiats-0.3.11/bin/patsopt
shrinking /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/lib/ats2-postiats-0.3.11/bin/myatscc
shrinking /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/lib/ats2-postiats-0.3.11/bin/patscc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/lib  /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/bin
patching script interpreter paths in /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12
/nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/bin/patsopt: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/bin/myatscc: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12/bin/patscc: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/bwyjf35jn73hs7a400zdbjrcn6mnvvdw-ats2-0.3.12...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ats2

Partial log (click to expand)

shrinking /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/lib/ats2-postiats-0.3.11/bin/patscc
shrinking /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/lib/ats2-postiats-0.3.11/bin/patsopt
shrinking /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/lib/ats2-postiats-0.3.11/bin/myatscc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/lib  /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/bin
patching script interpreter paths in /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12
/nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/bin/patscc: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/bin/patsopt: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12/bin/myatscc: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/bxkbarsi58f96gwx70yf6nx2as4lxns9-ats2-0.3.12...

@bbarker
Copy link
Contributor Author

bbarker commented Oct 24, 2018

Thanks @joachifm . Should I issue the build command next time like you did? Also, is there anything else that needs to be done for this to go in?

@joachifm
Copy link
Contributor

@bbarker to issue commands to the build bot you need to register yourself over at https://github.com/NixOS/ofborg first.

Apart from that it'd be nice to know if you have tested this. I have no knowledge of the package so any info would make it easier for me to integrate.

@joachifm
Copy link
Contributor

Ah, I see you're listed as a maintainer of the package; I take it that means you have a vested interest in keeping this working :)

@joachifm joachifm merged commit 017bb02 into NixOS:master Oct 24, 2018
bbarker added a commit to bbarker/ofborg that referenced this pull request Oct 24, 2018
@bbarker
Add bbarker to extra-known-users
d541d7d 
I'd like to be able to trigger builds in order to expedite the PR review process, see e.g. NixOS/nixpkgs#48877

Thanks!
@bbarker bbarker mentioned this pull request Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbarker @joachifm @GrahamcOfBorg