Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black: 18.6b4 -> 18.9b0 #47914

Merged
merged 1 commit into from Oct 6, 2018
Merged

black: 18.6b4 -> 18.9b0 #47914

merged 1 commit into from Oct 6, 2018

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Oct 5, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner October 5, 2018 12:58
@xeji
Copy link
Contributor

xeji commented Oct 5, 2018

@GrahamcOfBorg build python36Packages.black python36Packages.pyls-black

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python36Packages.black, python36Packages.pyls-black

Partial log (click to expand)

            py36=config["py36"],
            pyi=config["pyi"],
>           skip_string_normalization=config["skip_string_normalization"],
        )
E       TypeError: from_configuration() missing 1 required keyword-only argument: 'skip_numeric_underscore_normalization'

/nix/store/843qjw57mvp2g2n3lpabxjk76kwl6jg7-python3.6-pyls-black-0.2.1/lib/python3.6/site-packages/pyls_black/plugin.py:49: TypeError
====================== 9 failed, 2 passed in 0.42 seconds ======================
builder for '/nix/store/npjby99q72gxz0ljvgbraqfy08sh6r4r-python3.6-pyls-black-0.2.1.drv' failed with exit code 1
error: build of '/nix/store/npjby99q72gxz0ljvgbraqfy08sh6r4r-python3.6-pyls-black-0.2.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python36Packages.black, python36Packages.pyls-black

Partial log (click to expand)

            py36=config["py36"],
            pyi=config["pyi"],
>           skip_string_normalization=config["skip_string_normalization"],
        )
E       TypeError: from_configuration() missing 1 required keyword-only argument: 'skip_numeric_underscore_normalization'

/nix/store/jl5yr7gvbdp6nsfq7ydy0l84mxgj1l9n-python3.6-pyls-black-0.2.1/lib/python3.6/site-packages/pyls_black/plugin.py:49: TypeError
====================== 9 failed, 2 passed in 0.90 seconds ======================
builder for '/nix/store/m1g04i49l52dh118fpnnzxw3aa10spbx-python3.6-pyls-black-0.2.1.drv' failed with exit code 1
error: build of '/nix/store/m1g04i49l52dh118fpnnzxw3aa10spbx-python3.6-pyls-black-0.2.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python36Packages.black, python36Packages.pyls-black

Partial log (click to expand)

            py36=config["py36"],
            pyi=config["pyi"],
>           skip_string_normalization=config["skip_string_normalization"],
        )
E       TypeError: from_configuration() missing 1 required keyword-only argument: 'skip_numeric_underscore_normalization'

/nix/store/i63m88jj88y00pz0gwmcl0ww9yi2as56-python3.6-pyls-black-0.2.1/lib/python3.6/site-packages/pyls_black/plugin.py:49: TypeError
====================== 9 failed, 2 passed in 0.47 seconds ======================
builder for '/nix/store/6cahzni790nnyn3z8jvbnqdgm5h8v0w1-python3.6-pyls-black-0.2.1.drv' failed with exit code 1
error: build of '/nix/store/6cahzni790nnyn3z8jvbnqdgm5h8v0w1-python3.6-pyls-black-0.2.1.drv' failed

xeji
xeji suggested changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test failures.

@pmiddend
Copy link
Contributor Author

pmiddend commented Oct 5, 2018

Hmm, there is already a PR for pyls-black that fixes the issue. Is there an easy way to incorporate this PR (consisting of three commits apparently) into pyls-black?

@pmiddend
Copy link
Contributor Author

pmiddend commented Oct 5, 2018

See rupert/pyls-black#6

@xeji
Copy link
Contributor

xeji commented Oct 5, 2018

You could fetchpatch the commits from the upstream PR author's fork. But I'm not sure it's worth the effort. I would just temporarily disable tests with doCheck = false; with a comment pointing to the upstream PR and a reminder to remove this on the next version bump.

@pmiddend
Copy link
Contributor Author

pmiddend commented Oct 6, 2018

@xeji Okay, I did that. Seems to work.

@xeji
Copy link
Contributor

xeji commented Oct 6, 2018

@GrahamcOfBorg build python36Packages.black python36Packages.pyls-black

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python36Packages.black, python36Packages.pyls-black

Partial log (click to expand)

E                  return True
E              last_call()
E              # standalone comment at ENDMARKER
E            : Expected diff isn't equal to the actual. If you made changes to expression.py and this is an anticipated difference, overwrite tests/expression.diff with /private/tmp/nix-build-python3.6-black-18.9b0.drv-0/blk_v2fryyev.log

tests/test_black.py:294: AssertionError
======== 1 failed, 73 passed, 12 skipped, 2 deselected in 12.76 seconds ========
builder for '/nix/store/vp45ifcz0gfb7mm2wfjcnaiajypk3kgv-python3.6-black-18.9b0.drv' failed with exit code 1
cannot build derivation '/nix/store/17505rzqc0bb82m6vl2gjcjpn3ch1z41-python3.6-pyls-black-0.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/17505rzqc0bb82m6vl2gjcjpn3ch1z41-python3.6-pyls-black-0.2.1.drv', '/nix/store/vp45ifcz0gfb7mm2wfjcnaiajypk3kgv-python3.6-black-18.9b0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.black, python36Packages.pyls-black

Partial log (click to expand)

Successfully installed pyls-black-0.2.1
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vcxz79wm52w5yxibchsynbrjf7yx0840-python3.6-pyls-black-0.2.1
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vcxz79wm52w5yxibchsynbrjf7yx0840-python3.6-pyls-black-0.2.1/lib
patching script interpreter paths in /nix/store/vcxz79wm52w5yxibchsynbrjf7yx0840-python3.6-pyls-black-0.2.1
checking for references to /build in /nix/store/vcxz79wm52w5yxibchsynbrjf7yx0840-python3.6-pyls-black-0.2.1...
/nix/store/nanx4wp3qm0sfjlcfcwblxk4qrsfrr30-python3.6-black-18.9b0
/nix/store/vcxz79wm52w5yxibchsynbrjf7yx0840-python3.6-pyls-black-0.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.black, python36Packages.pyls-black

Partial log (click to expand)

Successfully installed pyls-black-0.2.1
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/njs2zklhybxp9z4xabg5y0f2vbj4nr8a-python3.6-pyls-black-0.2.1
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/njs2zklhybxp9z4xabg5y0f2vbj4nr8a-python3.6-pyls-black-0.2.1/lib
patching script interpreter paths in /nix/store/njs2zklhybxp9z4xabg5y0f2vbj4nr8a-python3.6-pyls-black-0.2.1
checking for references to /build in /nix/store/njs2zklhybxp9z4xabg5y0f2vbj4nr8a-python3.6-pyls-black-0.2.1...
/nix/store/gvs0w0fsg4iiiv1l7cva30bf98ikvsan-python3.6-black-18.9b0
/nix/store/njs2zklhybxp9z4xabg5y0f2vbj4nr8a-python3.6-pyls-black-0.2.1

@xeji
Copy link
Contributor

xeji commented Oct 6, 2018

There still is a test failure for black on darwin, but that failure was there before this PR: https://hydra.nixos.org/job/nixpkgs/trunk/python36Packages.black.x86_64-darwin , so let's ignore it for now.

@xeji xeji merged commit d2608d2 into NixOS:master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmiddend @xeji @GrahamcOfBorg