slurm: add lz4 dependency #47922

bhipple · 2018-10-05T17:03:58Z

Slurm looks for lz4 by default, and if it finds it can improve its compression techniques

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Slurm looks for lz4 by default, and if it finds it can improve its compression techniques

bhipple · 2018-10-05T17:04:14Z

@GrahamcOfBorg build slurm

bhipple · 2018-10-05T17:04:36Z

CC @markuskowa @jagajaga

GrahamcOfBorg · 2018-10-05T17:06:30Z

Failure on x86_64-linux (full log)

Attempted: slurm

Partial log (click to expand)

collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:578: sbcast] Error 1
make[3]: Leaving directory '/build/source/src/sbcast'
make[2]: *** [Makefile:563: all-recursive] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:690: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:589: all] Error 2
builder for '/nix/store/c4sdajh1sszivganr7dp00w2jdbqz2y6-slurm-18.08.0-1.drv' failed with exit code 2
error: build of '/nix/store/c4sdajh1sszivganr7dp00w2jdbqz2y6-slurm-18.08.0-1.drv' failed

GrahamcOfBorg · 2018-10-05T17:06:51Z

Failure on aarch64-linux (full log)

Attempted: slurm

Partial log (click to expand)

collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:578: sbcast] Error 1
make[3]: Leaving directory '/build/source/src/sbcast'
make[2]: *** [Makefile:563: all-recursive] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:690: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:589: all] Error 2
builder for '/nix/store/z290ga5l27n11kyqk2z90pf6lbmagcd5-slurm-18.08.0-1.drv' failed with exit code 2
error: build of '/nix/store/z290ga5l27n11kyqk2z90pf6lbmagcd5-slurm-18.08.0-1.drv' failed

Mic92 · 2018-10-05T17:25:41Z

@GrahamcOfBorg test slurm

GrahamcOfBorg · 2018-10-05T17:29:03Z

Failure on aarch64-linux (full log)

Attempted: tests.slurm

Partial log (click to expand)

cannot build derivation '/nix/store/a8acy94g21syixqarbfkzs89z25mh97r-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gjaxw9shadmpx57rlc7jg6awq6ryy6b8-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/2kzfgj6ni4makqcc1cqsf8gvwij0g1yr-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/c4iqgfd1rrh88q9lwd7wqqgpw8zpgx8i-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/f1p3xdic0g56sk390lv451s6pvfk1sy2-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kxnm09bzbp4wxnnzdlw0g7y7fsnijc5i-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/sxmjpfah3chmf7nm67ia252nakzv8rzh-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ykrpdx6dirdqymlfzdj9mf9p19kacz7x-nixos-test-driver-slurm.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/mjp2iwz1rs9rkdr28ca143qzwyjxw9a5-vm-test-run-slurm.drv': 1 dependencies couldn't be built
error: build of '/nix/store/mjp2iwz1rs9rkdr28ca143qzwyjxw9a5-vm-test-run-slurm.drv' failed

GrahamcOfBorg · 2018-10-05T17:29:41Z

Failure on x86_64-linux (full log)

Attempted: tests.slurm

Partial log (click to expand)

cannot build derivation '/nix/store/ms2k7c654l32qifnyl1nzcb3lkf2gy4r-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/w4s5nd8fszpiqxynxc0kjjv135nbxc93-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0adcm9cff9n4ah601zrq5q127n9zgikk-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0j4nc2bh3czvh41n6sf77xn9r1wsmpxa-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hczvmal765bzvxj3wjnx9fvz910lgfqq-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/m63wv7d82pbl40qh2ikkn22p5aiswiwb-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xfd5818gp5dxsalwsrrap5fbzgv2xrhi-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gavr5f8gg6yccbp15j2mrqnxypy0q21a-nixos-test-driver-slurm.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/wxsgylx97yaxl5lxys3m4vnjp36dcvg1-vm-test-run-slurm.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wxsgylx97yaxl5lxys3m4vnjp36dcvg1-vm-test-run-slurm.drv' failed

GrahamcOfBorg · 2018-10-05T17:57:06Z

Failure on aarch64-linux (full log)

Attempted: slurm

Partial log (click to expand)

collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:578: sbcast] Error 1
make[3]: Leaving directory '/build/source/src/sbcast'
make[2]: *** [Makefile:563: all-recursive] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:690: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:589: all] Error 2
builder for '/nix/store/z290ga5l27n11kyqk2z90pf6lbmagcd5-slurm-18.08.0-1.drv' failed with exit code 2
error: build of '/nix/store/z290ga5l27n11kyqk2z90pf6lbmagcd5-slurm-18.08.0-1.drv' failed

GrahamcOfBorg · 2018-10-05T18:02:01Z

Failure on x86_64-linux (full log)

Attempted: slurm

Partial log (click to expand)

collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:578: sbcast] Error 1
make[3]: Leaving directory '/build/source/src/sbcast'
make[2]: *** [Makefile:563: all-recursive] Error 1
make[2]: Leaving directory '/build/source/src'
make[1]: *** [Makefile:690: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:589: all] Error 2
builder for '/nix/store/c4sdajh1sszivganr7dp00w2jdbqz2y6-slurm-18.08.0-1.drv' failed with exit code 2
error: build of '/nix/store/c4sdajh1sszivganr7dp00w2jdbqz2y6-slurm-18.08.0-1.drv' failed

markuskowa · 2018-10-05T20:06:25Z

What feature does adding lz4 activate (other than compression for sbcast)?

markuskowa · 2018-10-06T11:08:35Z

pkgs/servers/computing/slurm/default.nix

      "--with-hwloc=${hwloc.dev}"
-      "--with-freeipmi=${freeipmi}"
+      "--with-lz4=${lz4}"


Using the dev output here works: --with-lz4=${lz4.dev}.
Would you mind also adding "--with-zlib=${zlib}" ?

bhipple · 2018-10-06T21:04:25Z

@GrahamcOfBorg test slurm

bhipple · 2018-10-06T21:11:16Z

What feature does adding lz4 activate (other than compression for sbcast)?

That's the only one I can see, but I'll admit I have an ulterior motive: I'm trying to compile this pkg on RedHat without sandboxes, and without specifying the NixPkg lz4 it's finding the system one and getting itself confused half-way through the build. Strangely it succeeded with a mix of system and nix lz4's when I added the configure flag and didn't have lz4.dev, but I've now also built it successfully at home on NixOS.

GrahamcOfBorg · 2018-10-06T21:17:35Z

Success on x86_64-linux (full log)

Attempted: tests.slurm

Partial log (click to expand)

test script finished in 59.29s
cleaning up
killing node3 (pid 597)
killing node1 (pid 609)
killing node2 (pid 621)
killing control (pid 633)
killing submit (pid 645)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/aspd2gyq5nwr7p81y1yxynq23y7qrnvs-vm-test-run-slurm

GrahamcOfBorg · 2018-10-06T21:21:19Z

Success on aarch64-linux (full log)

Attempted: slurm

Partial log (click to expand)

/nix/store/wn5wa1ibz4d05ssbx3imjrdyy49lbm78-slurm-18.08.0-1

GrahamcOfBorg · 2018-10-06T21:21:46Z

Success on aarch64-linux (full log)

Attempted: tests.slurm

Partial log (click to expand)

test script finished in 328.67s
cleaning up
killing node3 (pid 631)
killing node1 (pid 643)
killing control (pid 657)
killing submit (pid 670)
killing node2 (pid 683)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/yiv5yxvrj2aqjcxbn5cpg1anx9gyhayh-vm-test-run-slurm

GrahamcOfBorg · 2018-10-06T21:24:02Z

Success on x86_64-linux (full log)

Attempted: slurm

Partial log (click to expand)

gzipping man pages under /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1/lib  /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1/bin  /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1/sbin
patching script interpreter paths in /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1
checking for references to /build in /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1...
moving /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1/sbin/* to /nix/store/669yw8krb2nhk0r7w5n33063plmnwiys-slurm-18.08.0-1/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/iyab16wbvhyydic6s2vr1mbp5radvmrv-slurm-18.08.0-1-dev
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/iyab16wbvhyydic6s2vr1mbp5radvmrv-slurm-18.08.0-1-dev
checking for references to /build in /nix/store/iyab16wbvhyydic6s2vr1mbp5radvmrv-slurm-18.08.0-1-dev...

markuskowa · 2018-10-08T08:29:42Z

From my side this PR is good to be merged.

bhipple · 2018-10-10T00:08:54Z

Ping @Mic92 mind taking another look? I think this is ready to be merged.

slurm: add lz4 dependency

2ed17db

Slurm looks for lz4 by default, and if it finds it can improve its compression techniques

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 5, 2018

markuskowa reviewed Oct 6, 2018

View reviewed changes

Add zlib; swap to lz4.dev

2a1fa9a

Mic92 merged commit acc2bd1 into NixOS:master Oct 10, 2018

bhipple deleted the u/slurm branch February 27, 2019 23:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

slurm: add lz4 dependency #47922

slurm: add lz4 dependency #47922

bhipple commented Oct 5, 2018 •

edited

bhipple commented Oct 5, 2018

bhipple commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

Mic92 commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

markuskowa commented Oct 5, 2018 •

edited

markuskowa Oct 6, 2018

bhipple commented Oct 6, 2018

bhipple commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

markuskowa commented Oct 8, 2018

bhipple commented Oct 10, 2018

slurm: add lz4 dependency #47922

slurm: add lz4 dependency #47922

Conversation

bhipple commented Oct 5, 2018 • edited

Things done

bhipple commented Oct 5, 2018

bhipple commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

Mic92 commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

GrahamcOfBorg commented Oct 5, 2018

markuskowa commented Oct 5, 2018 • edited

markuskowa Oct 6, 2018

Choose a reason for hiding this comment

bhipple commented Oct 6, 2018

bhipple commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

GrahamcOfBorg commented Oct 6, 2018

markuskowa commented Oct 8, 2018

bhipple commented Oct 10, 2018

bhipple commented Oct 5, 2018 •

edited

markuskowa commented Oct 5, 2018 •

edited