Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-tree: 0.20.0 -> 0.21.0 #49577

Merged
merged 1 commit into from Nov 1, 2018
Merged

cargo-tree: 0.20.0 -> 0.21.0 #49577

merged 1 commit into from Nov 1, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 1, 2018

Motivation for this change

Changes (distilled from git commits):

  • Built against Cargo 2.30.
  • Add support for excluding dev dependencies.
  • Better error reporting.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-tree

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0
shrinking /nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0/bin/cargo-tree
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0/bin
patching script interpreter paths in /nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0
checking for references to /build in /nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0...
/nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-tree

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0
shrinking /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0/bin/cargo-tree
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0/bin
patching script interpreter paths in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0
checking for references to /build in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0...
/nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0

@dywedir
Copy link
Member

dywedir commented Nov 1, 2018

Let's check darwin build
@GrahamcOfBorg build cargo-tree

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cargo-tree

Partial log (click to expand)

/nix/store/s5s9k6sl16d8l912fqx41bjl6f3m197w-cargo-tree-0.21.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cargo-tree

Partial log (click to expand)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6psl6z1aljn9pjsrflzw0ijwwz9bbbnp-cargo-tree-0.21.0/bin
patching script interpreter paths in /nix/store/6psl6z1aljn9pjsrflzw0ijwwz9bbbnp-cargo-tree-0.21.0
/nix/store/6psl6z1aljn9pjsrflzw0ijwwz9bbbnp-cargo-tree-0.21.0

@dywedir dywedir merged commit 6258a35 into NixOS:master Nov 1, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cargo-tree

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0
shrinking /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0/bin/cargo-tree
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0/bin
patching script interpreter paths in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0
checking for references to /build in /nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0...
/nix/store/xllr9rn2khn5wiczaimc9dfniswa1am6-cargo-tree-0.21.0

@danieldk danieldk deleted the cargo-tree-0.21.0 branch November 1, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @GrahamcOfBorg @dywedir