Retry some times while trying to refresh user tokens #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayhem
approved these changes
Nov 1, 2018
listenbrainz/domain/spotify.py
Outdated
| @@ -68,7 +68,17 @@ def refresh_user_token(spotify_user): | |||
| user (domain.spotify.Spotify): the same user with updated tokens | |||
| """ | |||
| auth = get_spotify_oauth() | |||
| new_token = auth.refresh_access_token(spotify_user.refresh_token) | |||
|
|
|||
| retries = 5 | |||
There was a problem hiding this comment.
either make this a config or a constant we can define at the top. Burying this in the code is no good.
listenbrainz/domain/spotify.py
Outdated
| new_token = None | ||
| while retries > 0: | ||
| new_token = auth.refresh_access_token(spotify_user.refresh_token) | ||
| if new_token is not None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a sentry error for this in the Spotify importer.