Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brightnessctl: fix udev and clean unnecessary make flags #49579

Merged
merged 1 commit into from Nov 4, 2018
Merged

brightnessctl: fix udev and clean unnecessary make flags #49579

merged 1 commit into from Nov 4, 2018

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Nov 1, 2018 •
edited

Motivation for this change

The Makefile of the package now installs udev rules file correctly by default and so additional flags are not needed. Also the --replace %k '*' breaks the udev permissions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 1, 2018

cc @dje4321

@dje4321
Copy link
Contributor

dje4321 commented Nov 2, 2018

Looks good to me. Dont use nixos anymore

@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2018

@dje4321 do you want to be dropped from maintainers then?

@megheaiulian do you want to add yourself?

@megheaiulian
Copy link
Contributor Author

I'm ok with that. Should I update the meta ?

@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2018

Please do.

@joachifm joachifm merged commit e594af8 into NixOS:master Nov 4, 2018
@megheaiulian megheaiulian deleted the feature/brightnessctl-tweaks branch November 4, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@megheaiulian @Mic92 @dje4321 @7c6f434c @joachifm @GrahamcOfBorg