androidenv.androidsdk: patch x64 interpreter path of emulator{,-check} #49564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Mic92
reviewed
Oct 31, 2018
|
|
||
| ${stdenv.lib.optionalString (stdenv.hostPlatform.system == "x86_64-linux") '' | ||
| for i in emulator emulator-check | ||
| do | ||
| patchelf --set-interpreter ${stdenv.cc.libc.out}/lib/ld-linux-x86-64.so.2 $i |
There was a problem hiding this comment.
There is this pull request that also extends the rpath: https://github.com/NixOS/nixpkgs/pull/49515/files
There was a problem hiding this comment.
Hmm, I was able to run the binaries just by changing the interpreter, but maybe there were bugs I wasn't hitting.
There was a problem hiding this comment.
After thinking about it a bit I think it might be also not necessary because the wrapper already puts the same shared library directory with LD_LIBRARY_PATH into the scope.
|
Closing in favor of #49515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
emulatorandemulator-checkbinaries error with the messageNo such file or directory, due to a hard-coded interpreter path:sandboxinnix.confon non-NixOS)[ ] macOS(changes only effect x86-64 linux)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)