Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version librepcb-unstable: 2018-06-28 -> 2018-10-31 #49559

Merged
merged 1 commit into from Nov 3, 2018
Merged

bump version librepcb-unstable: 2018-06-28 -> 2018-10-31 #49559

merged 1 commit into from Nov 3, 2018

Conversation

cybre-finn
Copy link
Contributor

Motivation for this change

update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2018

@ikarulus could you amend your commit message according to guidelines please?
librepcb-unstable: 2018-06-28 -> 2018-10-31

LGTM otherwise.

@cybre-finn
Copy link
Contributor Author

Can I actually also PR this to the release-18.09 branch without further evaluation? It seemed to me as librepcb changed the syntax of their libraries which renders the current available version unusable.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2018

@GrahamcOfBorg build librepcb

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2018

@ikarulus yes if the current version in 18.09 is not fully working then the backport is justified.
You can make another PR targeting release-18.09 branch and cherry-pick the commit from this PR

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: librepcb

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031
shrinking /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031/bin/librepcb
shrinking /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031/bin/librepcb-cli
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031/bin
patching script interpreter paths in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031
checking for references to /build in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031...
postPatchMkspecs
postPatchMkspecs
/nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: librepcb

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031
shrinking /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031/bin/librepcb-cli
shrinking /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031/bin/librepcb
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031/bin
patching script interpreter paths in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031
checking for references to /build in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031...
postPatchMkspecs
postPatchMkspecs
/nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031

@c0bw3b c0bw3b merged commit 848f2f3 into NixOS:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cybre-finn @c0bw3b @GrahamcOfBorg @Janik-Haag