Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightstep-tracer-cpp: 0.36 -> 0.8.1 #49572

Merged
merged 1 commit into from Nov 1, 2018
Merged

lightstep-tracer-cpp: 0.36 -> 0.8.1 #49572

merged 1 commit into from Nov 1, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Nov 1, 2018 •
edited by srhb

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vaibhavsagar vaibhavsagar changed the title [WIP] lightstep-tracer-cpp: 0.36 -> 0.8.1 lightstep-tracer-cpp: 0.36 -> 0.8.1 Nov 1, 2018
@srhb
Copy link
Contributor

srhb commented Nov 1, 2018

@GrahamcOfBorg build lightstep-tracer-cpp

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: lightstep-tracer-cpp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lightstep-tracer-cpp

Partial log (click to expand)

-- Installing: /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1/lib/liblightstep_tracer.so
-- Installing: /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1/lib/liblightstep_tracer.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1
shrinking /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1/lib/liblightstep_tracer.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1/lib
patching script interpreter paths in /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1
checking for references to /build in /nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1...
/nix/store/gg6w3b1k0kia96c3ba42ad7p8r3szg7n-lightstep-tracer-cpp-0.8.1

@srhb
Copy link
Contributor

srhb commented Nov 1, 2018

Only envoy, which is currently broken, depends on this, so not possible to test dependents as-is. .so looks OK from minimal inspection.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lightstep-tracer-cpp

Partial log (click to expand)

-- Installing: /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1/lib/liblightstep_tracer.so
-- Installing: /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1/lib/liblightstep_tracer.a
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1
shrinking /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1/lib/liblightstep_tracer.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1/lib
patching script interpreter paths in /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1
checking for references to /build in /nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1...
/nix/store/sibjyc6qk4jyvsq80cw15v66qq6804w0-lightstep-tracer-cpp-0.8.1

@srhb srhb merged commit 9fce8d5 into NixOS:master Nov 1, 2018
@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the bump-lightstep-tracer-cpp branch November 1, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @srhb @GrahamcOfBorg