Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.systems.platforms: Add more ARM autodetection for 18.09 #49568

Merged
merged 1 commit into from Nov 1, 2018
Merged

lib.systems.platforms: Add more ARM autodetection for 18.09 #49568

merged 1 commit into from Nov 1, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #49567. Harmlessly allows platform to be omitted in more cases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from nbp as a code owner November 1, 2018 00:22
@Ericson2314 Ericson2314 merged commit 89fb76c into NixOS:release-18.09 Nov 1, 2018
@Ericson2314 Ericson2314 deleted the arm-auto-detect branch November 1, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg