Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libarchive: 3.3.2 -> 3.3.3 #49583

Closed
wants to merge 1 commit into from
Closed

libarchive: 3.3.2 -> 3.3.3 #49583

wants to merge 1 commit into from

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Nov 1, 2018

Motivation for this change

cc #47122

Update includes patches for sec issues:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@periklis
libarchive: 3.3.2 -> 3.3.3
f04dd9b 
Update includes patches for sec issues:
- CVE-2017-14166
- CVE-2017-14501
- CVE-2017-14502
- Upstream includes patch for libressl version check
@periklis
Copy link
Contributor Author

periklis commented Nov 1, 2018

cc @ckauhaus

@fpletz
Copy link
Member

fpletz commented Nov 1, 2018

This release also fixes CVE-2017-14503.

@fpletz
Copy link
Member

fpletz commented Nov 1, 2018

@GrahamcOfBorg build libarchive ostree fwup

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libarchive, fwup

The following builds were skipped because they don't evaluate on x86_64-darwin: ostree

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-fwup-1.2.5.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-fwup-1.2.5.drv-0/source'
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/sa4xy6faxg57y27cpdj9y75i4jqja4n4-fwup-1.2.5/bin
patching script interpreter paths in /nix/store/sa4xy6faxg57y27cpdj9y75i4jqja4n4-fwup-1.2.5
/nix/store/sa4xy6faxg57y27cpdj9y75i4jqja4n4-fwup-1.2.5/bin/img2fwup: interpreter directive changed from "/bin/bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
/nix/store/ki83cn3r6r8qb9b7rb6yvqm1xaka9q33-libarchive-3.3.3
/nix/store/sa4xy6faxg57y27cpdj9y75i4jqja4n4-fwup-1.2.5

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: libarchive, ostree, fwup

Partial log (click to expand)

cannot build derivation '/nix/store/91jf9v5y33darkx51kwmlg5914kbj9k1-vala-0.38.10.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yq9y6vfpk0vy4gcslsxwr5ifkqgpvjab-vala-0.40.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/87c0wfz3r4ixmyc4ril5dkxzbr50ljxf-gjs-1.52.3.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/1ysp7sadds9bx545v5rm0rmsyb0jwf4q-libsecret-0.18.5.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bxyr79imb8ga39jsnyp3d6awcbjhzski-libsoup-2.62.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/y0crim14j7j19br88w3ciwz52rbjbx7q-pinentry-1.1.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/p3fzrz1pax37xic7x668clpyd0sfd7vk-gnupg-2.2.10.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wymi6x0karbzn1ak3g53l8rbprn79n3g-gpgme-1.12.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gzwbawhrm3h86naadw4zvwyc1h7ybl7z-ostree-2018.8.drv': 4 dependencies couldn't be built
error: build of '/nix/store/gzwbawhrm3h86naadw4zvwyc1h7ybl7z-ostree-2018.8.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libarchive, ostree, fwup

Partial log (click to expand)

/nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-archivez.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-pull-subpath.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic-root.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic-user-only.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic-user.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic.sh: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5zff22y4nr21cqxf3rn52rl302la0643-ostree-2018.8-installedTests...
/nix/store/5nv4mv5c53nf3gvbkg6ah62l4y01kjwv-libarchive-3.3.3
/nix/store/67p5wp97p3iqyiwv4mw7wzzlbj0x6d5p-ostree-2018.8
/nix/store/ypi2f3sq0lvx6d8pj9blhpxg667ib8cl-fwup-1.2.5

@ckauhaus
Copy link
Contributor

ckauhaus commented Nov 2, 2018

The timeout on x86_64-linux seems to be due to the size of the closure which must be rebuilt. Apart from that, the update looks fine.

@lheckemann
Copy link
Member

Given the rebuild amount, should this go to staging?

Mic92 pushed a commit that referenced this pull request Nov 15, 2018
@periklis @Mic92
libarchive: 3.3.2 -> 3.3.3
95fa7b6 
Update includes patches for sec issues:
- CVE-2017-14166
- CVE-2017-14501
- CVE-2017-14502
- Upstream includes patch for libressl version check

fixes #49583
@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

pushed to staging in 95fa7b6

@Mic92 Mic92 closed this Nov 15, 2018
Mic92 pushed a commit that referenced this pull request Nov 15, 2018
@periklis @Mic92
libarchive: 3.3.2 -> 3.3.3
8ea0aa3 
Update includes patches for sec issues:
- CVE-2017-14166
- CVE-2017-14501
- CVE-2017-14502
- Upstream includes patch for libressl version check

fixes #49583

(cherry picked from commit 95fa7b6)
@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

staging-18.09 backport in 8ea0aa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@periklis @fpletz @GrahamcOfBorg @ckauhaus @lheckemann @Mic92