Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages_8_x: add ttf2eot #49575

Closed
wants to merge 1 commit into from
Closed

nodePackages_8_x: add ttf2eot #49575

wants to merge 1 commit into from

Conversation

arromer
Copy link
Contributor

@arromer arromer commented Nov 1, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Nov 1, 2018
View reviewed changes
pkgs/development/node-packages/node-packages-v10.json Outdated
@@ -6,4 +6,5 @@
, "node-gyp-build"
, "node-pre-gyp"
, "pnpm"
, "ttf2eot"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to node-packages-v8.json instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review. Updated.

@arromer arromer changed the title nodePackages_10_x: add ttf2eot nodePackages_8_x: add ttf2eot Nov 2, 2018
@uri-canva
Copy link
Contributor

ping @Mic92

@Mic92 Mic92 closed this in 2718fea Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arromer @uri-canva @Mic92 @GrahamcOfBorg @Janik-Haag