Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leveldb: 1.18 -> 1.20 #49587

Merged
merged 1 commit into from Nov 1, 2018
Merged

leveldb: 1.18 -> 1.20 #49587

merged 1 commit into from Nov 1, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 1, 2018

Motivation for this change

Changelog:

1.20: https://github.com/google/leveldb/releases/tag/v1.20
1.19: https://github.com/google/leveldb/releases/tag/v1.19

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: leveldb

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20
shrinking /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20/bin/leveldbutil
shrinking /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20/lib/libleveldb.so.1.20
shrinking /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20/lib/libleveldb.so.1
shrinking /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20/lib/libleveldb.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20/lib  /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20/bin
patching script interpreter paths in /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20
checking for references to /build in /nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20...
/nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: leveldb

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20
shrinking /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20/lib/libleveldb.so.1.20
shrinking /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20/lib/libleveldb.so.1
shrinking /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20/lib/libleveldb.so
shrinking /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20/bin/leveldbutil
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20/lib  /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20/bin
patching script interpreter paths in /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20
checking for references to /build in /nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20...
/nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

let's check darwin
@GrahamcOfBorg build leveldb

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: leveldb

Partial log (click to expand)

/nix/store/7j3vwallyhqk82v1p8a46cnbgficjvm5-leveldb-1.20

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: leveldb

Partial log (click to expand)

/nix/store/3v8v6p9a53bbxjh9dlnvnawvk062fvin-leveldb-1.20

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: leveldb

Partial log (click to expand)

clang++  -I. -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT -O2 -DNDEBUG util/env_test.cc out-static/db/builder.o out-static/db/c.o out-static/db/db_impl.o out-static/db/db_iter.o out-static/db/dbformat.o out-static/db/dumpfile.o out-static/db/filename.o out-static/db/log_reader.o out-static/db/log_writer.o out-static/db/memtable.o out-static/db/repair.o out-static/db/table_cache.o out-static/db/version_edit.o out-static/db/version_set.o out-static/db/write_batch.o out-static/table/block.o out-static/table/block_builder.o out-static/table/filter_block.o out-static/table/format.o out-static/table/iterator.o out-static/table/merger.o out-static/table/table.o out-static/table/table_builder.o out-static/table/two_level_iterator.o out-static/util/arena.o out-static/util/bloom.o out-static/util/cache.o out-static/util/coding.o out-static/util/comparator.o out-static/util/crc32c.o out-static/util/env.o out-static/util/env_posix.o out-static/util/filter_policy.o out-static/util/hash.o out-static/util/histogram.o out-static/util/logging.o out-static/util/options.o out-static/util/status.o out-static/port/port_posix.o out-static/port/port_posix_sse.o out-static/util/testharness.o out-static/util/testutil.o -o out-static/env_test
clang++  -I. -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT -O2 -DNDEBUG util/hash_test.cc out-static/db/builder.o out-static/db/c.o out-static/db/db_impl.o out-static/db/db_iter.o out-static/db/dbformat.o out-static/db/dumpfile.o out-static/db/filename.o out-static/db/log_reader.o out-static/db/log_writer.o out-static/db/memtable.o out-static/db/repair.o out-static/db/table_cache.o out-static/db/version_edit.o out-static/db/version_set.o out-static/db/write_batch.o out-static/table/block.o out-static/table/block_builder.o out-static/table/filter_block.o out-static/table/format.o out-static/table/iterator.o out-static/table/merger.o out-static/table/table.o out-static/table/table_builder.o out-static/table/two_level_iterator.o out-static/util/arena.o out-static/util/bloom.o out-static/util/cache.o out-static/util/coding.o out-static/util/comparator.o out-static/util/crc32c.o out-static/util/env.o out-static/util/env_posix.o out-static/util/filter_policy.o out-static/util/hash.o out-static/util/histogram.o out-static/util/logging.o out-static/util/options.o out-static/util/status.o out-static/port/port_posix.o out-static/port/port_posix_sse.o out-static/util/testharness.o out-static/util/testutil.o -o out-static/hash_test
clang++  -I. -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT -O2 -DNDEBUG db/db_bench.cc out-static/db/builder.o out-static/db/c.o out-static/db/db_impl.o out-static/db/db_iter.o out-static/db/dbformat.o out-static/db/dumpfile.o out-static/db/filename.o out-static/db/log_reader.o out-static/db/log_writer.o out-static/db/memtable.o out-static/db/repair.o out-static/db/table_cache.o out-static/db/version_edit.o out-static/db/version_set.o out-static/db/write_batch.o out-static/table/block.o out-static/table/block_builder.o out-static/table/filter_block.o out-static/table/format.o out-static/table/iterator.o out-static/table/merger.o out-static/table/table.o out-static/table/table_builder.o out-static/table/two_level_iterator.o out-static/util/arena.o out-static/util/bloom.o out-static/util/cache.o out-static/util/coding.o out-static/util/comparator.o out-static/util/crc32c.o out-static/util/env.o out-static/util/env_posix.o out-static/util/filter_policy.o out-static/util/hash.o out-static/util/histogram.o out-static/util/logging.o out-static/util/options.o out-static/util/status.o out-static/port/port_posix.o out-static/port/port_posix_sse.o out-static/util/testutil.o -o out-static/db_bench
clang++  -I. -I./include -std=c++0x  -DOS_MACOSX -DLEVELDB_PLATFORM_POSIX -DLEVELDB_ATOMIC_PRESENT -O2 -DNDEBUG db/leveldbutil.cc out-static/db/builder.o out-static/db/c.o out-static/db/db_impl.o out-static/db/db_iter.o out-static/db/dbformat.o out-static/db/dumpfile.o out-static/db/filename.o out-static/db/log_reader.o out-static/db/log_writer.o out-static/db/memtable.o out-static/db/repair.o out-static/db/table_cache.o out-static/db/version_edit.o out-static/db/version_set.o out-static/db/write_batch.o out-static/table/block.o out-static/table/block_builder.o out-static/table/filter_block.o out-static/table/format.o out-static/table/iterator.o out-static/table/merger.o out-static/table/table.o out-static/table/table_builder.o out-static/table/two_level_iterator.o out-static/util/arena.o out-static/util/bloom.o out-static/util/cache.o out-static/util/coding.o out-static/util/comparator.o out-static/util/crc32c.o out-static/util/env.o out-static/util/env_posix.o out-static/util/filter_policy.o out-static/util/hash.o out-static/util/histogram.o out-static/util/logging.o out-static/util/options.o out-static/util/status.o out-static/port/port_posix.o out-static/port/port_posix_sse.o -o out-static/leveldbutil
installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rq39v3s1l6vc85wwmrxsmlpi4rnbjnx6-leveldb-1.20/lib  /nix/store/rq39v3s1l6vc85wwmrxsmlpi4rnbjnx6-leveldb-1.20/bin
patching script interpreter paths in /nix/store/rq39v3s1l6vc85wwmrxsmlpi4rnbjnx6-leveldb-1.20
/nix/store/rq39v3s1l6vc85wwmrxsmlpi4rnbjnx6-leveldb-1.20

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

Can't believe we still have a 4 yr old version. Thank you!

@xeji xeji merged commit 3f0fa62 into NixOS:master Nov 1, 2018
@danieldk danieldk deleted the leveldb-1.20 branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @GrahamcOfBorg @xeji