Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: enable extra configuration to the [Service] section #49069

Closed
wants to merge 1 commit into from
Closed

systemd: enable extra configuration to the [Service] section #49069

wants to merge 1 commit into from

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 24, 2018 •
edited

Motivation for this change

Enable extra configuration to the [Service] section

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

joachifm commented Oct 24, 2018 •
edited

Is this not already addressed by serviceConfig?
E.g., the example usage for this option seems covered by

let # for syntax highlighting
serviceConfig = {
  PrivateTmp = true;
  /* ... */
};

and so on for any additional [Service] directives one might wish to add.

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 24, 2018

Thank you, did not see this option.

@Izorkin Izorkin closed this Oct 24, 2018
@Izorkin Izorkin deleted the systemd-extraConfig branch October 25, 2018 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @joachifm @GrahamcOfBorg