HybridReverb2: init at 2.1.1 #49080
Merged
HybridReverb2: init at 2.1.1 #49080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphorien
reviewed
Oct 26, 2018
| }; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = owner; |
There was a problem hiding this comment.
if you prefer, you can write inherit owner;
symphorien
reviewed
Oct 26, 2018
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ cmake lv2 alsaLib libjack2 freetype libX11 gtk3 pcre |
There was a problem hiding this comment.
cmake is probably a nativeBuildInput
magnetophon
force-pushed
the
hybridreverb2
branch
from
4893f3f
to
37376cc
Compare
|
@symphorien Thanks, done! |
|
@GrahamcOfBorg build hybridreverb2 |
|
Unexpected error: command failed with exit code 1 on aarch64-linux (full log) Attempted: hybridreverb2 Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: hybridreverb2 Partial log (click to expand)
|
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: hybridreverb2 Partial log (click to expand)
|
magnetophon
force-pushed
the
hybridreverb2
branch
from
37376cc
to
6f05584
Compare
|
@xeji Thanks, done. |
|
@GrahamcOfBorg build hybridreverb2 |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: hybridreverb2 Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: hybridreverb2 Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: hybridreverb2 Partial log (click to expand)
|
xeji
suggested changes
Oct 31, 2018
magnetophon
force-pushed
the
hybridreverb2
branch
from
6f05584
to
6ba1fcf
Compare
|
@xeji: Fixed. Sorry for not testing my other fix. |
|
@GrahamcOfBorg build hybridreverb2 |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: hybridreverb2 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: hybridreverb2 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: hybridreverb2 Partial log (click to expand)
|
jpotier
reviewed
Oct 24, 2020
| DBversion = "1.0.0"; | ||
| in | ||
|
|
||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
rec is probably not needed, since you have a let block. I have not thoroughly checked though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)