Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildFHSUserEnv: use runScript in env #49077

Merged
merged 1 commit into from
Oct 30, 2018
Merged

buildFHSUserEnv: use runScript in env #49077

merged 1 commit into from
Oct 30, 2018
+1 −1

Conversation

kristoff3r
Copy link
Contributor

@kristoff3r kristoff3r commented Oct 24, 2018 •
edited
Loading

Motivation for this change

The example in buildFHSUserEnv's docs makes it seem like runScript will be run when using nix-shell, but currently it is only used when building. I would like to use another shell than bash in an FHS environment, so I think it should be fixed to work as implied in the docs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@kristoff3r
buildFHSUserEnv: use runScript in env
51eeac6 
This makes its behaviour conform to what is implied in the
documentation.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 24, 2018
@xeji
Copy link
Contributor

xeji commented Oct 30, 2018

Thank you for spotting this bug!

@xeji xeji merged commit 5e5e57c into NixOS:master Oct 30, 2018
ivan pushed a commit to ivan/nixpkgs that referenced this pull request Jan 25, 2019
@kristoff3r @ivan
buildFHSUserEnv: use runScript in env (NixOS#49077)
6f05dea 
This makes its behaviour conform to what is implied in the
documentation.
@ivan ivan mentioned this pull request Jan 25, 2019
Merged
10 tasks
Mic92 pushed a commit that referenced this pull request Jan 26, 2019
@kristoff3r @Mic92
buildFHSUserEnv: use runScript in env (#49077)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Mic92 Jörg Thalheim
GPG key ID: B3F5D81B0C6967C4
Expired
Verified
Learn about vigilant mode
a4ee02f 
This makes its behaviour conform to what is implied in the
documentation.

(cherry picked from commit 6f05dea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristoff3r @xeji @GrahamcOfBorg