Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python36Packages.dlib: 19.13 -> 19.16 #49070

Merged
merged 3 commits into from Oct 29, 2018

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.6-dlib/versions.

meta.description for python36Packages.dlib is: '"A general purpose cross-platform C++ machine learning library"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Outpath report (click to expand)

Outpath difference report
17 total rebuild paths

5 package rebuilds

5 x86_64-linux rebuilds
5 i686-linux rebuilds
2 x86_64-darwin rebuilds
5 aarch64-linux rebuilds

First ten rebuilds by attrpath
dlib
python27Packages.dlib
python27Packages.face_recognition
python36Packages.dlib
python36Packages.face_recognition

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/dbiymvay53xnz4vhipwz44dz25ylyxh5-python3.6-dlib-19.16 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A python36Packages.dlib https://github.com/r-ryantm/nixpkgs/archive/c41603ab1b4e3e6c4314be22080355234d6aa0f6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/dbiymvay53xnz4vhipwz44dz25ylyxh5-python3.6-dlib-19.16
ls -la /nix/store/dbiymvay53xnz4vhipwz44dz25ylyxh5-python3.6-dlib-19.16/bin

cc @christopherpoole @Ma27 for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/python3.6-dlib/versions
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python36Packages.dlib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.dlib

Partial log (click to expand)

tools/python/test/test_point.py ...                                      [ 43%]
tools/python/test/test_range.py .....                                    [ 50%]
tools/python/test/test_rgb_pixel.py .                                    [ 52%]
tools/python/test/test_sparse_vector.py ....                             [ 57%]
tools/python/test/test_svm_c_trainer.py ............                     [ 74%]
tools/python/test/test_vector.py ..................                      [100%]

===================== 66 passed, 5 skipped in 1.76 seconds =====================
pytestcachePhase
/nix/store/pj4pba1xn728bq2imyncl9jdsxfn985x-python3.6-dlib-19.16

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python36Packages.dlib

Partial log (click to expand)

[ 97%] Building CXX object CMakeFiles/dlib_python.dir/src/numpy_returns.cpp.o
[ 98%] Building CXX object CMakeFiles/dlib_python.dir/src/line.cpp.o
[100%] Linking CXX shared module /build/source/dlib.cpython-36m-x86_64-linux-gnu.so
[100%] Built target dlib_python
============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/source, inifile:
/nix/store/9pifap75pkb9ifmdqh0irn8wgc3q38s6-stdenv-linux/setup: line 1298:  2835 Illegal instruction     /nix/store/bwfygfcdvis9wd1c1v51xwnwhw1hx0a0-python3-3.6.6/bin/python3.6m nix_run_setup test
builder for '/nix/store/c8idrynyfdfgnj357zjjs5kq2d0hsqj2-python3.6-dlib-19.16.drv' failed with exit code 132
error: build of '/nix/store/c8idrynyfdfgnj357zjjs5kq2d0hsqj2-python3.6-dlib-19.16.drv' failed

@Ma27 Ma27 self-assigned this Oct 24, 2018
@Ma27
Copy link
Member

Ma27 commented Oct 24, 2018

not sure if I have sufficient time to test this tonight, but I'd like to have a deeper look at this (IIRC last time dlib caused some issues after an upgrade)

@Ma27
Copy link
Member

Ma27 commented Oct 29, 2018

the entire setup is somehow weird: although we have a working artifact on Hydra I can break the build of dlib-19.13-python3.6 by appending a noop in a hook to alter the derivation hash.

Building this manually using nix-shell -A works perfectly fine though.

@Ma27
Copy link
Member

Ma27 commented Oct 29, 2018

adding --no USE_AVX_INSTRUCTIONS fixes the issue btw. Will push the change to @r-ryantm's branch later to see if borg succeeds then as well

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python36Packages.dlib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.dlib

Partial log (click to expand)

tools/python/test/test_point.py ...                                      [ 43%]
tools/python/test/test_range.py .....                                    [ 50%]
tools/python/test/test_rgb_pixel.py .                                    [ 52%]
tools/python/test/test_sparse_vector.py ....                             [ 57%]
tools/python/test/test_svm_c_trainer.py ............                     [ 74%]
tools/python/test/test_vector.py ..................                      [100%]

===================== 66 passed, 5 skipped in 1.99 seconds =====================
pytestcachePhase
/nix/store/0vkm30ys10rvjsn4ax3ar2x176pbi094-python3.6-dlib-19.16

Initially the expression was quite small (just inherited properties from
`pkgs.dlib`), but the more it grows the better it is to store it into
its own file.
@Ma27
Copy link
Member

Ma27 commented Oct 29, 2018

The change looks fine now and should be safe to merge.
I'll wait about 24h now in case anyone wants to review and request changes, then I'd merge this to master.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python36Packages.dlib

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.dlib

Partial log (click to expand)

/nix/store/0vkm30ys10rvjsn4ax3ar2x176pbi094-python3.6-dlib-19.16

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.dlib

Partial log (click to expand)

tools/python/test/test_point.py ...                                      [ 43%]
tools/python/test/test_range.py .....                                    [ 50%]
tools/python/test/test_rgb_pixel.py .                                    [ 52%]
tools/python/test/test_sparse_vector.py ....                             [ 57%]
tools/python/test/test_svm_c_trainer.py ............                     [ 74%]
tools/python/test/test_vector.py ..................                      [100%]

===================== 66 passed, 5 skipped in 0.92 seconds =====================
pytestcachePhase
/nix/store/7xing55bz8kzfr0ar9rv7r1gm2sri8mh-python3.6-dlib-19.16

@FRidh FRidh merged commit e6c0b6f into NixOS:master Oct 29, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.dlib

Partial log (click to expand)

tools/python/test/test_point.py ...                                      [ 43%]
tools/python/test/test_range.py .....                                    [ 50%]
tools/python/test/test_rgb_pixel.py .                                    [ 52%]
tools/python/test/test_sparse_vector.py ....                             [ 57%]
tools/python/test/test_svm_c_trainer.py ............                     [ 74%]
tools/python/test/test_vector.py ..................                      [100%]

===================== 66 passed, 5 skipped in 3.21 seconds =====================
pytestcachePhase
/nix/store/7xing55bz8kzfr0ar9rv7r1gm2sri8mh-python3.6-dlib-19.16

@r-ryantm r-ryantm deleted the auto-update/python3.6-dlib branch November 17, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants