Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wolf-shaper: init at 0.1.6 #49087

Merged
merged 1 commit into from Oct 31, 2018
Merged

wolf-shaper: init at 0.1.6 #49087

merged 1 commit into from Oct 31, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 25, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 29, 2018

@GrahamcOfBorg build wolf-shaper

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: wolf-shaper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: wolf-shaper

Partial log (click to expand)

make -C dpf/dgl
make[1]: Entering directory '/build/source/dpf/dgl'
g++ src/Application.cpp -Wall -Wextra -pipe -MD -MP -fPIC -DPIC -DNDEBUG -O2 -mtune=generic -msse -msse2 -fdata-sections -ffunction-sections -fvisibility=hidden -std=c++11 -fvisibility-inlines-hidden  -I/nix/store/5bajvphlym932blmj8n6l0d5rkvp8ya3-libX11-1.6.6-dev/include -I/nix/store/wwxbr47wd66jm4h73s48fwzs5szr3sqf-xproto-7.0.31/include -I/nix/store/j6agwvfyjqjw4s108cl3yh84bzl93klj-kbproto-1.0.7/include -I/nix/store/6bfi1znjs6j5llsf42hbbr4w7va4cdcs-mesa-noglu-18.2.2-dev/include -I. -Isrc -DDGL_NAMESPACE=WOLF_SHAPER_DGL -Wno-type-limits -fpermissive -c -o src/Application.cpp.o
g++: error: unrecognized command line option '-msse'; did you mean '-fdse'?
g++: error: unrecognized command line option '-msse2'
make[1]: *** [Makefile:72: src/Application.cpp.o] Error 1
make[1]: Leaving directory '/build/source/dpf/dgl'
make: *** [Makefile:36: libs] Error 2
builder for '/nix/store/ng1g2zqfg454ilfsj05d27ad6b86rlin-wolf-shaper-0.1.6.drv' failed with exit code 2
error: build of '/nix/store/ng1g2zqfg454ilfsj05d27ad6b86rlin-wolf-shaper-0.1.6.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wolf-shaper

Partial log (click to expand)

shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/lv2/wolf-shaper.lv2/wolf-shaper_ui.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/lv2/wolf-shaper.lv2/wolf-shaper_dsp.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/dssi/wolf-shaper-dssi.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/dssi/wolf-shaper-dssi/wolf-shaper-dssi_ui
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/vst/wolf-shaper-vst.so
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib  /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/bin
patching script interpreter paths in /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6
checking for references to /build in /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6...
/nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6

xeji
xeji suggested changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doesn't support aarch64. Please restrict platforms to x86_64-linux.

@magnetophon
Copy link
Member Author

@xeji Thanks, done.

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build wolf-shaper

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wolf-shaper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: wolf-shaper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wolf-shaper

Partial log (click to expand)

shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/dssi/wolf-shaper-dssi.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/vst/wolf-shaper-vst.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/lv2/wolf-shaper.lv2/wolf-shaper_ui.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib/lv2/wolf-shaper.lv2/wolf-shaper_dsp.so
shrinking /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/bin/wolf-shaper
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/lib  /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6/bin
patching script interpreter paths in /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6
checking for references to /build in /nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6...
/nix/store/r8ji5rkr88q8n2rdyi2bp3w84p1xhsgf-wolf-shaper-0.1.6

@xeji xeji merged commit 0f601b7 into NixOS:master Oct 31, 2018
@magnetophon magnetophon deleted the wolf-shaper branch October 31, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @xeji @GrahamcOfBorg