Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlroots.examples: prefix example binaries #49078

Merged
merged 1 commit into from Oct 28, 2018
Merged

Conversation

colemickens
Copy link
Member

Motivation for this change

cc: @primeos @Synthetica9

The wlroots examples are somewhat generically named. Can we prefix them, like I've done here?

(For example, there is an example named touch, which might pop up in unexpected, unfun ways)

(Alternatively, we could prefix with wlr-?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member

primeos commented Oct 24, 2018

Hm, I'll think about it tomorrow. The examples output isn't really meant to be added to systemPackages / end up in a user's PATH so I didn't worry about that but if someone would add it that would indeed cause problems (but they could also be avoided with meta.priority).

But basically wlroots.examples is only intended for testing purposes and not to be actually "installed" (there probably shouldn't even be an output for it, but I thought it might be useful for testing purposes and in case we'll write NixOS tests at some point).

@colemickens
Copy link
Member Author

Okay, I understand. I don't mind, either way. Now that I think about it, my primary use for it (idle-inhibit) has been replaced by a simpler sentinel-file/swayidle solution, anyway. Thanks for your time.

@Synthetica9
Copy link
Member

Maybe add a switch to build the examples? It might be useful to not build it by default, but still have a way to build it if you really want to.

@primeos primeos merged commit 8ea2f0d into NixOS:master Oct 28, 2018
@primeos
Copy link
Member

primeos commented Oct 28, 2018

Thank you and sorry for the delay :o

@colemickens colemickens deleted the pr-wlroots branch November 2, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants