google-fonts: fix on macOS #49085
Merged
google-fonts: fix on macOS #49085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
|
@GrahamcOfBorg build google-fonts |
|
Success on aarch64-linux (full log) Attempted: google-fonts Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: google-fonts Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: google-fonts Partial log (click to expand)
|
Mic92
reviewed
Oct 25, 2018
| @@ -39,7 +39,7 @@ stdenv.mkDerivation rec { | |||
| dest=$out/share/fonts/truetype | |||
| mkdir -p $dest | |||
| find . -name "*.ttf" -exec cp -v {} $dest \; | |||
| chmod -x $dest/*.ttf | |||
| (cd $dest; chmod -x *.ttf) | |||
There was a problem hiding this comment.
It might better to use xargs and the install command which can also set the executable bit directly.
There was a problem hiding this comment.
If we're golfing, lines 40-42 seem equivalent to something like
find . -name '*.ttf' -exec install -Dt $dest '{}' +
There was a problem hiding this comment.
Though xargs may be more portable ...
There was a problem hiding this comment.
If you have a lot of small file xargs is also faster because install only spawned a few times instead executing it for every file.
There was a problem hiding this comment.
install --target directory FILE...
There was a problem hiding this comment.
Note that with GNU find, + builds command lines similarly to xargs.
hamishmack
force-pushed
the
google-fonts-macos
branch
from
9affb1f
to
9cc3aaa
Compare
|
Updated to use @joachifm's suggestion. I had to pass |
|
@GrahamcOfBorg build google-fonts |
|
Success on aarch64-linux (full log) Attempted: google-fonts Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: google-fonts Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: google-fonts Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
Small change to the way
chmod -xis invoked so that the argument list will not be too long for macOS.macOS has a lower limit on the argument list size and
nix-build '<nixpkgs>' -A google-fontsfails because the argument list passed tochmodis too long.nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)More
Fixes issue #
cc @
Please note, that points are not mandatory, but rather desired.