nvie/vim-flake8: init at 2018-09-21 #47774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also set a default value for https://github.com/nvie/vim-flake8/blob/master/autoload/flake8.vim#L73 or is this better left to the user? |
Using the package when |
|
Does it actually make a difference for flake8 if it is python2 or python3? |
|
TBH, I don't know whether the Python version that's used to run Flake8
affects its assumptions regarding the Python files being validated.
If any of the flake8 packages works equally well, I suppose we could add an
explicit dependency to an arbitrary one. However, I imagine that might
trigger further problems if another version of flake8 is already installed.
In short, I'm not quite knowledgeable enough on what is common Nix practice
in such cases to really weigh in on the matter.
…On Wed, Oct 3, 2018 at 10:31 PM Jörg Thalheim ***@***.***> wrote:
Does it actually make a difference for flake8 if it is python2 or python3?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#47774 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANqWTk24W9W8hUevRBeVyG4adQXO1A_ks5uhR6xgaJpZM4XGSrz>
.[image: Web Bug from
https://github.com/notifications/beacon/AANqWWLbLEMlg_bpxU3Q2sx1CX3JnHNGks5uhR6xgaJpZM4XGSrz.gif]
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/NixOS/nixpkgs","title":"NixOS/nixpkgs","subtitle":"GitHub
repository","main_image_url":"
https://assets-cdn.github.com/images/email/message_cards/header.png
","avatar_image_url":"
https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open
in ***@***.***
in #47774: Does it actually make a difference for flake8 if it is python2
or python3?"}],"action":{"name":"View Pull Request","url":"
#47774 (comment)"}}} [
{ ***@***.***": "http://schema.org", ***@***.***": "EmailMessage",
"potentialAction": { ***@***.***": "ViewAction", "target": "
#47774 (comment)",
"url": "#47774 (comment)",
"name": "View Pull Request" }, "description": "View this Pull Request on
GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "
https://github.com" } }, { ***@***.***": "MessageCard", ***@***.***": "
http://schema.org/extensions", "hideOriginalBody": "false", "originator":
"AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [NixOS/nixpkgs]
nvie/vim-flake8: init at 2018-09-21 (#47774)", "sections": [ { "text": "",
"activityTitle": "**Jörg Thalheim**", "activityImage": "
https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": ***@***.***", "facts": [ ] } ], "potentialAction": [ {
"name": "Add a comment", ***@***.***": "ActionCard", "inputs": [ {
"isMultiLine": true, ***@***.***": "TextInput", "id": "IssueComment",
"isRequired": false } ], "actions": [ { "name": "Comment", ***@***.***":
"HttpPOST", "target": "https://api.github.com", "body":
"{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\":
\"NixOS/nixpkgs\",\n\"issueId\": 47774,\n\"IssueComment\":
\"{{IssueComment.value}}\"\n}" } ] }, { "targets": [ { "os": "default",
"uri": "#47774 (comment)"
} ], ***@***.***": "OpenUri", "name": "View on GitHub" }, { "name":
"Unsubscribe", ***@***.***": "HttpPOST", "target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\":
387525363\n}" } ], "themeColor": "26292E" } ]
--
Klaas van Schelven
+31 6 811 599 10
|
![https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open](https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open){kind=link}
|
The common practice is to make stuff works by out-of-box with sensible defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
nvie/vim-flake8 is a useful vim plugin (it introduces flake8 integration for vim)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)