Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshot-qt: 2.4.2 -> 2.4.3 #47745

Merged
merged 1 commit into from Nov 25, 2018
Merged

openshot-qt: 2.4.2 -> 2.4.3 #47745

merged 1 commit into from Nov 25, 2018

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 3, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openshot-qt/versions.

meta.description for openshot-qt is: '"Free, open-source video editor"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/bin/openshot-qt had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/bin/..openshot-qt-wrapped-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/bin/.openshot-qt-wrapped had a zero exit code or showed the expected version
  • 0 of 3 passed binary check by having a zero exit code.
  • 0 of 3 passed binary check by having the new version present in output.
  • found 2.4.3 with grep in /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3
  • directory tree listing: https://gist.github.com/e60145e796d9dbac21f67ffb2d1312ec
  • du listing: https://gist.github.com/2e57f08c4866af699ff45bfa4640b72f
Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

  1. Install cachix from https://cachix.org/
  2. Use r-ryantm's cache: 
    cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:

nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/97b739f256248e1dd5f98313d2fa2155e106c993.tar.gz -p openshot-qt
ls -la /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3

cc @AndersonTorres for testing.

@r-ryantm
openshot-qt: 2.4.2 -> 2.4.3
97b739f 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/openshot-qt/versions
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openshot-qt

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openshot-qt

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3/lib  /nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3/bin
patching script interpreter paths in /nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3
/nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language/generate_translations.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/0cymph4p1781g26ihhldnz74wzi0m2y0-python3-3.6.6/bin/python3"
/nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language/show_translations.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/0cymph4p1781g26ihhldnz74wzi0m2y0-python3-3.6.6/bin/python3"
/nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language/test_translations.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/0cymph4p1781g26ihhldnz74wzi0m2y0-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3...
wrapping `/nix/store/pwny633jfxhfvsbmr639kkb23bfabrpf-openshot-qt-2.4.3/bin/.openshot-qt-wrapped'...
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openshot-qt

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/lib  /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/bin
patching script interpreter paths in /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3
/nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language/test_translations.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python3"
/nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language/generate_translations.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python3"
/nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language/show_translations.py: interpreter directive changed from "/usr/bin/python3" to "/nix/store/1c4zshbxizcsvyj46fwf5jj10h41wf6i-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3...
wrapping `/nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/bin/.openshot-qt-wrapped'...
postPatchMkspecs

@Mic92
Copy link
Member

Mic92 commented Oct 3, 2018 

$ openshot-qt
Compiled translation resources missing!
Loading translations from: /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language
Loaded modules from installed directory: /nix/store/g6brfdi2yxdaa1m0yc42mzdd6bbsmykc-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt
      launch:INFO ------------------------------------------------
      launch:INFO    OpenShot (version 2.4.3)
      launch:INFO ------------------------------------------------
         app:INFO openshot-qt version: 2.4.3
         app:INFO libopenshot version: 0.2.1
         app:INFO platform: Linux-4.18.11-x86_64-with-glibc2.3.4
         app:INFO processor:
         app:INFO machine: x86_64
         app:INFO python version: 3.6.6
         app:INFO qt5 version: 5.11.1
         app:INFO pyqt5 version: 5.10.1
    language:INFO Qt Detected Languages: ['en-DK']
    language:INFO LANG Environment Variable: en_US.UTF-8
    language:INFO LOCALE Environment Variable:
    language:INFO OpenShot Preference Language: Default

needs an upgrade of libopenshot as well.

timokau
timokau requested changes Oct 20, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libopenshot upgrade and ideally a trivial test case to catch this kind of error

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018 •
edited

Related: #48410 libsForQt5.libopenshot: 0.2.1 -> 0.2.2

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

It starts the same but the GUI is actually translated after startup so translations are loaded from the nix store

$ ./result/bin/openshot-qt
Compiled translation resources missing!
Loading translations from: /nix/store/91h4g63lnwhsachymypg35fhm1zl5s9z-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt/language
Loaded modules from installed directory: /nix/store/91h4g63lnwhsachymypg35fhm1zl5s9z-openshot-qt-2.4.3/lib/python3.6/site-packages/openshot_qt
      launch:INFO ------------------------------------------------
      launch:INFO    OpenShot (version 2.4.3)
      launch:INFO ------------------------------------------------
         app:INFO openshot-qt version: 2.4.3
         app:INFO libopenshot version: 0.2.2
         app:INFO platform: Linux-4.14.82-x86_64-with-glibc2.3.4
         app:INFO processor: 
         app:INFO machine: x86_64
         app:INFO python version: 3.6.6
         app:INFO qt5 version: 5.11.1
         app:INFO pyqt5 version: 5.10.1
    language:INFO Qt Detected Languages: ['fr']
    language:INFO LANG Environment Variable: fr_FR.UTF-8
    language:INFO LOCALE Environment Variable: 
    language:INFO OpenShot Preference Language: Default

@c0bw3b c0bw3b merged commit 6c74e75 into NixOS:master Nov 25, 2018
@r-ryantm r-ryantm deleted the auto-update/openshot-qt branch December 8, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @GrahamcOfBorg @Mic92 @c0bw3b @timokau