Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/munin: move from /var/run to /run #47775

Merged
merged 1 commit into from Oct 21, 2018
Merged

nixos/munin: move from /var/run to /run #47775

merged 1 commit into from Oct 21, 2018

Conversation

florianjacob
Copy link
Contributor

as using /var/run now emits a warning by systemd's tmpfiles.d.
As /var/run is already a symlink to /run, this can't break anything, and
data does not need to be migrated.

Motivation for this change

Without this patch, systemd-tmpfiles shows this error when munin is enabled:

[/etc/tmpfiles.d/nixos.conf:8] Line references path below legacy directory /var/run/, updating /var/run/munin → /run/munin; please update the tmpfiles.d/ drop-in file accordingly.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@florianjacob
nixos/munin: move from /var/run to /run
c54aa26 
as using /var/run now emits a warning by systemd's tmpfiles.d.
As /var/run is already a symlink to /run, this can't break anything, and
data does not need to be migrated.
@peterhoeg peterhoeg mentioned this pull request Oct 4, 2018
Closed
9 tasks
@florianjacob
Copy link
Contributor Author

florianjacob commented Oct 7, 2018 •
edited

@volth I was not aware of problems with tmpfiles, thank you for that hint!

I'd still argue that moving this, and everything else as in #47856, to /run makes sense as that directory is oficially deprecated by systemd, even if it does not produce an error message anymore.

@c0bw3b c0bw3b merged commit cb9237d into NixOS:master Oct 21, 2018
@florianjacob florianjacob deleted the munin-var-run-to-run branch October 21, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianjacob @c0bw3b @GrahamcOfBorg