Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: 0.28.1 -> 0.29.0 #47765

Merged
merged 1 commit into from Oct 3, 2018
Merged

minikube: 0.28.1 -> 0.29.0 #47765

merged 1 commit into from Oct 3, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 3, 2018 •
edited

Motivation for this change

Bump to latest minikube version.
This hard-code kubernetes version as the upstream python script is broken/not-up-to-date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vdemeester
minikube: 0.28.1 -> 0.29.0
ba98a7a 
Hard-code kubernetes version as the upstream python script is broken/not-up-to-date

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@Mic92
Copy link
Member

Mic92 commented Oct 3, 2018

@GrahamcOfBorg build minikube

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: minikube

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aq72ypdn28p1bq2njwk8vc1n7qs0qwjs-minikube-0.29.0-bin
shrinking /nix/store/aq72ypdn28p1bq2njwk8vc1n7qs0qwjs-minikube-0.29.0-bin/bin/minikube
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aq72ypdn28p1bq2njwk8vc1n7qs0qwjs-minikube-0.29.0-bin/bin
patching script interpreter paths in /nix/store/aq72ypdn28p1bq2njwk8vc1n7qs0qwjs-minikube-0.29.0-bin
checking for references to /build in /nix/store/aq72ypdn28p1bq2njwk8vc1n7qs0qwjs-minikube-0.29.0-bin...
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: minikube

Partial log (click to expand)

find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
find: '/nix/store/zri60izvifqpyihsc6cvjgwh74fza9wx-minikube-0.29.0': No such file or directory
/nix/store/bzs4pqskaf50kmryn8zdzq3ydvvz72qx-minikube-0.29.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: minikube

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lad559bw9a37d7smzlaxx4naz25izizy-minikube-0.29.0-bin
shrinking /nix/store/lad559bw9a37d7smzlaxx4naz25izizy-minikube-0.29.0-bin/bin/minikube
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lad559bw9a37d7smzlaxx4naz25izizy-minikube-0.29.0-bin/bin
patching script interpreter paths in /nix/store/lad559bw9a37d7smzlaxx4naz25izizy-minikube-0.29.0-bin
checking for references to /build in /nix/store/lad559bw9a37d7smzlaxx4naz25izizy-minikube-0.29.0-bin...
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/lad559bw9a37d7smzlaxx4naz25izizy-minikube-0.29.0-bin

@Mic92 Mic92 merged commit e680208 into NixOS:master Oct 3, 2018
@vdemeester vdemeester deleted the update-minikube branch October 4, 2018 06:07
srhb pushed a commit that referenced this pull request Oct 12, 2018
@vdemeester @srhb
minikube: 0.28.1 -> 0.29.0
c0c5ea1 
Hard-code kubernetes version as the upstream python script is broken/not-up-to-date

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
(cherry picked from commit ba98a7a)
Backport of #47765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vdemeester @Mic92 @GrahamcOfBorg