Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc-arm-embedded: 6-2017-q2-update -> 7-2018-q2-update #47788

Merged

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 3, 2018

(+ update blackmagic to latest commit which includes gcc7 fixes)

(cherry picked from commit b3531b9)

Motivation for this change

We just updated gcc-arm-embedded in master to version 7. I think this is the change which should get into 18.09 release too, because otherwise we'll ship a rather old embedded compiler.

As discussed with @Mic92 in #47542 I am sending a pull request to "release-18.09", where I kept gcc-arm-embedded = gcc-arm-embedded-6; as requested, so only a new gcc-arm-embedded-7 package is added.

If you think we should point gcc-arm-embedded to version 7, I'll be happy to amend the commit and return the line gcc-arm-embedded = gcc-arm-embedded-7; back.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

+ update blackmagic to latest commit which includes gcc7 fixes

(cherry picked from commit b3531b9)
@matthewbauer matthewbauer merged commit c090089 into NixOS:release-18.09 Oct 3, 2018
@prusnak prusnak deleted the gcc-arm-embedded_update-18.09 branch October 3, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants