Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgnurl: 7.54.1 -> 7.61.1. #48792

Merged
merged 2 commits into from Oct 23, 2018
Merged

libgnurl: 7.54.1 -> 7.61.1. #48792

merged 2 commits into from Oct 23, 2018

Conversation

royneary
Copy link
Contributor

Motivation for this change

Bump to the latest version of libgnurl. In the previous version of the package HTTPS support was not compiled in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@royneary
libgnurl: 7.54.1 -> 7.61.1.
38ae308 
- fetch url updated (the mirror on gnunet.org seems no longer
maintained).
- most configure flags are not needed anymore since version 7.56.1 as
announced in the README
- flags -- without-ca-bundle and --with-ca-fallback are needed for
finding the CA certificates
- dependencies updated (copied from the guix package)
- license corrected
xeji
xeji reviewed Oct 22, 2018
View reviewed changes
pkgs/development/libraries/libgnurl/default.nix Outdated
'';
nativeBuildInputs = [ libtool groff perl pkgconfig python2 ];

buildInputs = [ gnutls zlib libidn ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like IDN support doesn't work with libidn anymore, see the configure log. You need libidn2 instead (and this requires libunistring as well).

Also I suggest to add nghttp2 here to enable HTTP2 support.

pkgs/development/libraries/libgnurl/default.nix Outdated

name = "libgnurl-${version}";

src = fetchurl {
url = "https://gnunet.org/sites/default/files/gnurl-${version}.tar.bz2";
sha256 = "0szbj352h95sgc9kbx9wzkgjksmg3g5k6cvlc7hz3wrbdh5gb0a4";
url = "https://ftp.gnu.org/gnu/gnunet/gnurl-${version}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use url = "mirror://gnu/gnunet/..." here. This automatically uses a mirror list provided in nixpkgs, see here.

pkgs/development/libraries/libgnurl/default.nix Show resolved Hide resolved
@royneary
Copy link
Contributor Author

Fixed as you suggested.

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg build libgnurl

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libgnurl

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgnurl

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1
shrinking /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1/bin/gnurl
shrinking /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1/lib/libgnurl.so.4.5.0
gzipping man pages under /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1/lib  /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1/bin
patching script interpreter paths in /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1
/nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1/bin/gnurl-config: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1...
/nix/store/zb31lq3nqqy5sp9q8siwnw19h1m6c12s-libgnurl-7.61.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libgnurl

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1
shrinking /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1/bin/gnurl
shrinking /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1/lib/libgnurl.so.4.5.0
gzipping man pages under /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1/lib  /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1/bin
patching script interpreter paths in /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1
/nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1/bin/gnurl-config: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1...
/nix/store/dkxcnp9swyc2zqn10p50djl1dv4mwy3b-libgnurl-7.61.1

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg build gnunet

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnunet

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnunet

Partial log (click to expand)

shrinking /nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/bin/gnunet-resolver
gzipping man pages under /nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/lib  /nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/bin
patching script interpreter paths in /nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1
/nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/bin/gnunet-download-manager.scm: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/bin/gnunet-gns-proxy-setup-ca: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1/bin/gnunet-gns-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1...
/nix/store/xr9631hh1y2g8vcah08i65y79wyp41y8-gnunet-0.10.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnunet

Partial log (click to expand)

shrinking /nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/bin/gnunet-vpn
gzipping man pages under /nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/lib  /nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/bin
patching script interpreter paths in /nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1
/nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/bin/gnunet-download-manager.scm: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/bin/gnunet-gns-proxy-setup-ca: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
/nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1/bin/gnunet-gns-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1...
/nix/store/im99fh94r6dianvxvjbck0cm6srp6gpz-gnunet-0.10.1

@xeji xeji merged commit 516681c into NixOS:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@royneary @xeji @GrahamcOfBorg @Janik-Haag